Feat: integrate batch allocator in processor allocator

[lacroixthomas]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind feature

What this PR does / Why we need it:

Bring the batch allocator improvement from this PR to the processorAllocator feature gate : #4176

Which issue(s) this PR fixes:

Part of #4190 and #3992

Special notes for your reviewer:

[agones-bot]

Build Failed 😭

Build Id: c114e430-ff0d-4839-957e-5fd66102b7b0

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[github-actions]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[lacroixthomas]

This is quite a "direct" import of the changes from the original PR, did minor updates on it
Will come back to it to ensure everything is fine in the code itself (might have seen some part that could be updated - improved) and also manually testing it with it all (actual allocations flow etc.)

[agones-bot]

Build Failed 😭

Build Id: c50b1a31-0600-48c2-95e8-4face7902b8e

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[lacroixthomas]

/gcbrun

[agones-bot]

Build Failed 😭

Build Id: 4246cd2b-53d1-4624-98df-3b0ca5e6fb97

Status: FAILURE

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[lacroixthomas]

/gcbrun

Step #1 - "e2e-feature-gates": Release "agones" does not exist. Installing it now.
Step #1 - "e2e-feature-gates": I0512 16:40:40.497273      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-ping: defaulted unspecified 'cpu' resource for containers [agones-ping] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.550869      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-extensions: defaulted unspecified 'cpu' resource for containers [agones-extensions] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.550922      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-controller: defaulted unspecified 'cpu' resource for containers [agones-controller] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.587701      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Deployment agones-system/agones-allocator: defaulted unspecified 'cpu' resource for containers [agones-allocator] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": I0512 16:40:40.828318      90 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
Step #1 - "e2e-feature-gates": I0512 16:40:40.867417      90 warnings.go:110] "Warning: AdmissionWebhookController: mutated namespaceselector of the webhooks to enforce GKE Autopilot policies."
Step #1 - "e2e-feature-gates": I0512 16:50:45.051070      90 warnings.go:110] "Warning: autopilot-default-resources-mutator:Autopilot updated Job agones-system/agones-delete-agones-resources: defaulted unspecified 'cpu' resource for containers [pre-delete-delete-agones-resources] (see http://g.co/gke/autopilot-defaults)."
Step #1 - "e2e-feature-gates": Error: release agones failed, and has been uninstalled due to atomic being set: context deadline exceeded
Step #1 - "e2e-feature-gates": make: *** [Makefile:446: install] Error 1

[agones-bot]

Build Succeeded 🥳

Build Id: ff1ca275-3f67-4710-8594-a3dcf6bd472f

The following development artifacts have been built, and will exist for the next 30 days:

• image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.58.0-dev-32c71b9
• image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.58.0-dev-32c71b9
• image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.58.0-dev-32c71b9-linux
• image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.58.0-dev-32c71b9
• image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.58.0-dev-32c71b9
• image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.58.0-dev-32c71b9
• Linux C++ SDK (build): agonessdk-1.58.0-dev-32c71b9-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.58.0-dev-32c71b9.zip

A preview of the website (the last 30 builds are retained):

• https://32c71b9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4559/head:pr_4559 && git checkout pr_4559
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.58.0-dev-32c71b9

[miai10]

Looks good

[miai10]

This needs to be fixed too: https://github.com/agones-dev/agones/pull/4176/changes#r2096804822