Add quality tools: mypy, pre-commit, Makefile

Author: g3force

.pre-commit-config.yaml

@@ -26,15 +26,9 @@ repos:
 
   - repo: local
     hooks:
-      - id: python-lint
-        name: python-lint
+      - id: python-check-fix
+        name: python-check-fix
         language: system
-        entry: "uv run poe lint"
-        types_or: [ python ]
-        pass_filenames: false
-      - id: python-ruff
-        name: python-ruff
-        language: system
-        entry: "uv run poe ruff"
+        entry: "make check-fix"
         types_or: [ python ]
         pass_filenames: false

Makefile

@@ -0,0 +1,26 @@
+.PHONY: all
+all: build
+
+
+.PHONY: build
+build:
+	uv sync --all-packages
+
+
+.PHONY: test
+test: build
+	uv run pytest
+
+
+.PHONY: check
+check: build test
+	uv run mypy .
+	uv run ruff check
+	uv run bandit -c pyproject.toml -r .
+	uv export --frozen --no-hashes | uv run pip-audit -r /dev/stdin
+
+
+.PHONY: check-fix
+check-fix: build
+	uv run ruff format
+	uv run ruff check --fix

adk/agenticlayer/a2a_starlette.py

@@ -17,7 +17,7 @@ def agent_to_a2a_starlette(agent: BaseAgent) -> Starlette:
 
     StarletteInstrumentor().instrument_app(app)
 
-    def health(_: Request):
+    def health(_: Request) -> JSONResponse:
         return JSONResponse(content={"status": "healthy"})
 
     app.add_route("/health", health)

adk/agenticlayer/otel.py

@@ -16,7 +16,7 @@
 from opentelemetry.sdk.trace.export import SimpleSpanProcessor
 
 
-def setup_otel():
+def setup_otel() -> None:
     # Traces
     _tracer_provider = trace_sdk.TracerProvider()
     _tracer_provider.add_span_processor(SimpleSpanProcessor(OTLPSpanExporter()))
@@ -29,20 +29,20 @@ def setup_otel():
     HTTPXClientInstrumentor().instrument()
 
     # Logs
-    provider = LoggerProvider()
-    provider.add_log_record_processor(BatchLogRecordProcessor(OTLPLogExporter()))
+    logger_provider = LoggerProvider()
+    logger_provider.add_log_record_processor(BatchLogRecordProcessor(OTLPLogExporter()))
     # Sets the global default logger provider
-    set_logger_provider(provider)
+    set_logger_provider(logger_provider)
 
-    handler = LoggingHandler(level=logging.NOTSET, logger_provider=provider)
+    handler = LoggingHandler(level=logging.NOTSET, logger_provider=logger_provider)
     log_level = os.environ.get("LOGLEVEL", "INFO")
     logging.getLogger().setLevel(log_level)
     # Attach OTLP handler to root logger
     logging.getLogger().addHandler(handler)
 
     # Metrics
-    provider = MeterProvider(
+    meter_provider = MeterProvider(
         metric_readers=[PeriodicExportingMetricReader(OTLPMetricExporter())],
     )
     # Sets the global default meter provider
-    metrics.set_meter_provider(provider)
+    metrics.set_meter_provider(meter_provider)

adk/pyproject.toml

@@ -12,9 +12,6 @@ dependencies = [
     "opentelemetry-instrumentation-httpx",
 ]
 
-[dependency-groups]
-test = []
-
 [build-system]
 requires = ["hatchling"]
 build-backend = "hatchling.build"

adk/tests/test_a2a_starlette.py

@@ -1,47 +1,36 @@
 import pytest
 from agenticlayer.a2a_starlette import agent_to_a2a_starlette
 from google.adk.agents.base_agent import BaseAgent
+from starlette.applications import Starlette
 from starlette.testclient import TestClient
 
 
-class SimpleTestAgent(BaseAgent):
-    """A simple test agent implementation."""
-
-    def __init__(self):
-        # BaseAgent is a Pydantic model that requires a name field
-        super().__init__(name="test_agent")
-
-    def process_request(self, request):
-        """Mock implementation of request processing."""
-        return {"response": "test response"}
-
-
 class TestA2AStarlette:
     """Test suite for the a2a_starlette module."""
 
     @pytest.fixture
-    def test_agent(self):
+    def test_agent(self) -> BaseAgent:
         """Create a test agent for testing."""
-        return SimpleTestAgent()
+        return BaseAgent(name="test_agent")
 
     @pytest.fixture
-    def starlette_app(self, test_agent):
+    def starlette_app(self, test_agent: BaseAgent) -> Starlette:
         """Create a Starlette app with the test agent."""
         return agent_to_a2a_starlette(test_agent)
 
     @pytest.fixture
-    def client(self, starlette_app):
+    def client(self, starlette_app: Starlette) -> TestClient:
         """Create a test client."""
         return TestClient(starlette_app)
 
-    def test_health_endpoint(self, client):
+    def test_health_endpoint(self, client: TestClient) -> None:
         """Test that the health check endpoint works."""
         response = client.get("/health")
         assert response.status_code == 200
         data = response.json()
         assert data["status"] == "healthy"
 
-    def test_agent_card_endpoint(self, starlette_app, client):
+    def test_agent_card_endpoint(self, starlette_app: Starlette, client: TestClient) -> None:
         """Test that the agent card is available at /.well-known/agent-card.json"""
 
         # Try the standard agent card endpoint

pyproject.toml

@@ -9,13 +9,19 @@ dependencies = [
 
 [dependency-groups]
 dev = [
-    "poethepoet>=0.31.1",
-    "mypy>=1.17.0",
-    "ruff>=0.12.7",
-    "pytest>=8.1.1",
+    "mypy[reports]>=1.12.0,<2",
+    "ruff>=0.11.2",
     "bandit[toml]>=1.7.8",
+    "pip-audit>=2.5,<3",
+    "pytest>=8.3.3,<9",
+    "pytest-cov>=5.0.0,<7",
+    "types-protobuf>=6.30.2.20250822",
 ]
 
+
+[tool.uv]
+package = false
+
 [tool.uv.workspace]
 members = [
     "adk",
@@ -24,24 +30,29 @@ members = [
 [tool.uv.sources]
 agentic-layer-sdk-adk = { workspace = true }
 
-[tool.poe.tasks]
-test = "pytest --strict-config"
-test-watch = "ptw ."
 
-format = "ruff format"
-lint = "ruff check --fix"
-ruff = ["format", "lint"]
+[build-system]
+requires = ["hatchling"]
+build-backend = "hatchling.build"
 
-bandit = "bandit -c pyproject.toml -r ."
-mypy = "mypy ."
 
-check = ["mypy", "bandit", "ruff", "test"]
+[tool.pytest.ini_options]
+minversion = "7.0"
+testpaths = "test"
+pythonpath = ["."]
+addopts = """\
+--strict-config \
+--cov app \
+--cov-report html \
+--import-mode=importlib \
+--show-capture=no \
+"""
+
 
 [tool.ruff]
 # Allow lines to be as long as 120.
 line-length = 120
 
-
 [tool.ruff.lint]
 # https://docs.astral.sh/ruff/rules/
 # I001 --> enable import sorting rules
@@ -52,11 +63,13 @@ line-length = 120
 # DTZ --> datetime timezone awareness
 extend-select = ["Q", "N", "I001", "PT", "TID251", "DTZ"]
 
+
 [tool.bandit]
-exclude_dirs = [".cache", ".venv"]
-skips = [
-    "B104", # hardcoded_bind_all_interfaces: Accept this for now.
-]
+exclude_dirs = [".venv"]
 
 [tool.bandit.assert_used]
 skips = ["*_test.py", "*test_*.py"]
+
+
+[tool.mypy]
+strict = true