Skip to content

Commit 593f0ce

Browse files
Copilotg3force
andcommitted
Address code review feedback on MCP tool descriptions test
Co-authored-by: g3force <779094+g3force@users.noreply.github.com>
1 parent 0b9a440 commit 593f0ce

1 file changed

Lines changed: 7 additions & 5 deletions

File tree

adk/tests/test_mcp_tool_descriptions.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""Integration test to verify MCP tool descriptions are included in agent instructions.
22
3-
This test reproduces the issue described in:
4-
https://github.com/agentic-layer/sdk-python/issues/XX
3+
This test reproduces the issue described in the GitHub issue about MCP tool descriptions
4+
not being contained in agent instructions.
55
66
The problem: When MCP tools are added to an agent, their descriptions should be
77
included in the agent's instructions so the LLM knows what each tool does. However,
@@ -210,9 +210,11 @@ def multiply(x: float, y: float) -> float:
210210
assert "add" in agent_instructions, "Tool name 'add' should be in instructions"
211211
assert "multiply" in agent_instructions, "Tool name 'multiply' should be in instructions"
212212

213-
# The descriptions should also be present
214-
assert "Add two numbers" in agent_instructions, "Tool description should be in instructions"
215-
assert "Multiply two numbers" in agent_instructions, "Tool description should be in instructions"
213+
# The full descriptions should be present
214+
assert "Add two numbers together" in agent_instructions, (
215+
"Full tool description should be in instructions"
216+
)
217+
assert "Multiply two numbers" in agent_instructions, "Full tool description should be in instructions"
216218

217219
# The format should be similar to sub-agent descriptions
218220
# (see agent.py lines 74-80 for reference)

0 commit comments

Comments
 (0)