Skip to content

Commit 26350fb

Browse files
committed
feat: Setup OTEL separately to make it optional
1 parent af6ec42 commit 26350fb

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

adk/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,13 @@ Basic usage example:
2020

2121
```python
2222
from agenticlayer.agent_to_a2a import to_a2a
23+
from agenticlayer.otel import setup_otel
2324

2425
root_agent = ... # Your ADK agent here
2526

27+
# Set up OpenTelemetry instrumentation, logging and metrics
28+
setup_otel()
29+
30+
# Create starlette app with A2A protocol
2631
app = to_a2a(root_agent)
2732
```

adk/agenticlayer/agent_to_a2a.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
from starlette.routing import Route
2323

2424
from .callback_tracer_plugin import CallbackTracerPlugin
25-
from .otel import setup_otel
2625

2726

2827
def to_a2a(agent: BaseAgent) -> Starlette:
@@ -43,13 +42,8 @@ def to_a2a(agent: BaseAgent) -> Starlette:
4342
# Set up ADK logging to ensure logs are visible when using uvicorn directly
4443
log_level = os.environ.get("LOGLEVEL", "INFO")
4544
setup_adk_logger(log_level) # type: ignore
46-
# Set log level for urllib to WARNING to reduce noise (like sending logs to OTLP)
47-
logging.getLogger("urllib3").setLevel(logging.WARNING)
4845
logger = logging.getLogger(__name__)
4946

50-
# Set up OpenTelemetry instrumentation, logging and metrics
51-
setup_otel()
52-
5347
async def create_runner() -> Runner:
5448
"""Create a runner for the agent."""
5549
return Runner(

adk/agenticlayer/otel.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@
1818
def setup_otel() -> None:
1919
"""Set up OpenTelemetry tracing, logging and metrics."""
2020

21+
# Set log level for urllib to WARNING to reduce noise (like sending logs to OTLP)
22+
logging.getLogger("urllib3").setLevel(logging.WARNING)
23+
2124
# Traces
2225
_tracer_provider = trace_sdk.TracerProvider()
2326
_tracer_provider.add_span_processor(SimpleSpanProcessor(OTLPSpanExporter()))

0 commit comments

Comments
 (0)