#1 Use GUID instead of int (auto identity) for domain entities as it is not dependant on the database so better fits clean architecture

Author: afsharm

src/ServicePlace.Core/BaseDomainEntity.cs

@@ -0,0 +1,7 @@
+public abstract class BaseDomainEntity
+{
+    public BaseDomainEntity()
+        => Id = Guid.NewGuid();
+        
+    public Guid Id { get; set; }
+}

src/ServicePlace.Core/Commands/CreateProviderCommand.cs

@@ -2,6 +2,6 @@ namespace ServicePlace.Core.Commands;
 
 public class CreateProviderCommand
 {
-    public int? ServiceId { get; set; }
+    public Guid? ServiceId { get; set; }
     public string? Name { get; set; }
 }

src/ServicePlace.Core/Commands/UpdateProvider.cs

@@ -2,6 +2,6 @@ namespace ServicePlace.Core.Commands;
 
 public class UpdateProvider
 {
-    public int Id { get; set; }
+    public Guid Id { get; set; }
     public string? Name { get; set; }
 }

src/ServicePlace.Core/Commands/UpdateService.cs

@@ -2,6 +2,6 @@ namespace ServicePlace.Core.Commands;
 
 public class UpdateService
 {
-    public int Id { get; set; }
+    public Guid Id { get; set; }
     public string? Name { get; set; }
 }

src/ServicePlace.Core/CommonService.cs

@@ -55,7 +55,7 @@ void ValidateCreateService(CreateService command)
             throw new Exception();
     }
 
-    public async Task<IEnumerable<ProviderDisplay>> GetProviderByServiceIdAsync(int serviceId)
+    public async Task<IEnumerable<ProviderDisplay>> GetProviderByServiceIdAsync(Guid serviceId)
     {
         return await _providerRepository.GetProviderByServiceIdAsync(serviceId);
     }
@@ -106,12 +106,12 @@ private void ValidateProviderName(string? name)
             throw new ArgumentException(ErrorMessageConstants.ShouldNotBeSmaller, nameof(name));
     }
 
-    public async Task DeleteServiceAsync(int serviceId)
+    public async Task DeleteServiceAsync(Guid serviceId)
     {
         await _serviceRepository.DeleteAsync(serviceId);
     }
 
-    public async Task<ServiceDisplay?> GetServiceByIdAsync(int serviceId)
+    public async Task<ServiceDisplay?> GetServiceByIdAsync(Guid serviceId)
     {
         return await _serviceRepository.GetServiceByIdAsync(serviceId);
     }
@@ -121,12 +121,12 @@ public async Task UpdateServiceAsync(UpdateService command)
         await _serviceRepository.UpdateServiceAsync(command);
     }
 
-    public async Task<ProviderDisplay?> GetProviderByIdAsync(int providerId)
+    public async Task<ProviderDisplay?> GetProviderByIdAsync(Guid providerId)
     {
         return await _providerRepository.GetProviderByIdAsync(providerId);
     }
 
-    public async Task DeleteProviderAsync(int providerId)
+    public async Task DeleteProviderAsync(Guid providerId)
     {
         await _providerRepository.DeleteAsync(providerId);
     }

src/ServicePlace.Core/Contracts/ICommonService.cs

@@ -9,12 +9,12 @@ public interface ICommonService
     Task<PagingResult<ProviderDisplay>> GetAllProvidersAsync(ProviderPagingQuery query);
     Task<IEnumerable<ServiceDisplay>> GetServicesAsync();
     Task<CreateServiceResult> CreateServiceAsync(CreateService command);
-    Task<IEnumerable<ProviderDisplay>> GetProviderByServiceIdAsync(int serviceId);
+    Task<IEnumerable<ProviderDisplay>> GetProviderByServiceIdAsync(Guid serviceId);
     Task UpdateProviderAsync(UpdateProvider command);
     Task<CreateProviderResult> CreateProviderAsync(CreateProviderCommand? command);
-    Task DeleteServiceAsync(int serviceId);
-    Task<ServiceDisplay?> GetServiceByIdAsync(int serviceId);
+    Task DeleteServiceAsync(Guid serviceId);
+    Task<ServiceDisplay?> GetServiceByIdAsync(Guid serviceId);
     Task UpdateServiceAsync(UpdateService command);
-    Task<ProviderDisplay?> GetProviderByIdAsync(int providerId);
-    Task DeleteProviderAsync(int providerId);
+    Task<ProviderDisplay?> GetProviderByIdAsync(Guid providerId);
+    Task DeleteProviderAsync(Guid providerId);
 }

src/ServicePlace.Core/Contracts/IProviderRepository.cs

@@ -7,11 +7,11 @@ namespace ServicePlace.Core.Contracts;
 public interface IProviderRepository
 {
     Task<PagingResult<ProviderDisplay>> GetAllProvidersAsync(ProviderPagingQuery query);
-    Task<IEnumerable<ProviderDisplay>> GetProviderByServiceIdAsync(int serviceId);
-    Task<ProviderDomain?> GetProviderAsync(int id);
+    Task<IEnumerable<ProviderDisplay>> GetProviderByServiceIdAsync(Guid serviceId);
+    Task<ProviderDomain?> GetProviderAsync(Guid id);
     void UpdateProvider(ProviderDomain provider);
-    Task<bool> AnyDuplicateAsync(string? name, int? serviceId);
+    Task<bool> AnyDuplicateAsync(string? name, Guid? serviceId);
     Task AddProviderAsync(ProviderDomain newProvider);
-    Task<ProviderDisplay?> GetProviderByIdAsync(int providerId);
-    Task DeleteAsync(int providerId);
+    Task<ProviderDisplay?> GetProviderByIdAsync(Guid providerId);
+    Task DeleteAsync(Guid providerId);
 }

src/ServicePlace.Core/Contracts/IServiceRepository.cs

@@ -8,7 +8,7 @@ public interface IServiceRepository
 {
     Task<IEnumerable<ServiceDisplay>> GetServicesAsync();
     Task AddAsync(ServiceDomain service);
-    Task DeleteAsync(int serviceId);
-    Task<ServiceDisplay?> GetServiceByIdAsync(int serviceId);
+    Task DeleteAsync(Guid serviceId);
+    Task<ServiceDisplay?> GetServiceByIdAsync(Guid serviceId);
     Task UpdateServiceAsync(UpdateService command);
 }

src/ServicePlace.Core/DomainEntities/ProviderDomain.cs

@@ -1,7 +1,6 @@
 namespace ServicePlace.Core.DomainEntities;
-public class ProviderDomain
+public class ProviderDomain: BaseDomainEntity
 {
     public string? Name { get; set; }
-    public int ServiceId { get; set; }
-    public int Id { get; set; }
+    public Guid ServiceId { get; set; }
 }

src/ServicePlace.Core/DomainEntities/ServiceDomain.cs

@@ -1,6 +1,5 @@
 namespace ServicePlace.Core.DomainEntities;
-public class ServiceDomain
+public class ServiceDomain: BaseDomainEntity
 {
     public string? Name { get; set; }
-    public int Id { get; set; }
 }