Allow a custom log filename to be specified via a paramater

Author: mostertb

Command/BaseCommand.php

@@ -72,7 +72,10 @@ protected function configure()
 
         $this
             ->addOption('log-level', 'l', InputOption::VALUE_REQUIRED,
-                'Override the Monolog logging level for this execution of the command. Valid values: ' . implode(',', array_keys(Logger::getLevels())))
+                'Override the Monolog logging level for this execution of the command. Valid values: ' .
+                implode(',', array_keys(Logger::getLevels())))
+            ->addOption('log-filename', null, InputOption::VALUE_REQUIRED, 'Specify a different file (relative to the '.
+                'kernel log directory) to send file logs to')
             ->addOption('locking', null, InputOption::VALUE_REQUIRED, 'Switches locking on/off');
 
         $this->advanceExecutionPhase(RuntimeConfig::PHASE_POST_CONFIGURE);

Helper/Config/RuntimeConfig.php

@@ -157,11 +157,14 @@ public function loadGlobalConfigFromContainer(ContainerInterface $container)
 
     public function loadConfigFromCommandParameters(InputInterface $input)
     {
-        // Override LogLevel to the one provided at runtime
+        // Logging parameters
         if ($input->getOption('log-level')) {
                 $loggerLevels = Logger::getLevels();
                 $this->setLogLevel($loggerLevels[strtoupper($input->getOption('log-level'))]);
         }
+        if ($input->getOption('log-filename')) {
+            $this->setLogFilename($input->getOption('log-filename'));
+        }
     }
 
     /**
@@ -353,7 +356,9 @@ public function setConsoleLogLineFormat($format)
      */
     public function setLogFilename($logFilename)
     {
-        if ($this->getExecutionPhase() > self::PHASE_INITIALISE) {
+        if($this->getExecutionPhase() == self::PHASE_LOAD_PARAMETERS){
+            $this->logConfigDebug('LOG FILENAME CHANGED VIA PARAMETER: '.$logFilename);
+        } elseif ($this->getExecutionPhase() > self::PHASE_INITIALISE) {
             throw new BaseCommandException('Cannot set manual logfile name. Logger is already initialised');
         }
 

Tests/Helper/Logging/LoggingEnhancementTest.php

@@ -385,4 +385,29 @@ public function testPushLogMessageOnPreInitQueue()
         );
     }
 
+    public function testChangeLogFilenameViaParameter()
+    {
+        $logFilename = 'customName.log';
+        $command = $this->registerCommand(new LoggingCommand());
+
+
+        $commandTester = $this->executeCommand($command, array('--log-filename'=>$logFilename));
+        $this->assertEquals(
+            $logFilename,
+            $command->getLogFilename(false),
+            'Log level does not appear to have been changed to '.$logFilename.' by the commandline parameter');
+
+        $this->assertTrue(
+            $this->doesLogfileExist($logFilename),
+            'A log file with the name '.$logFilename.' does not seem to have been created'
+        );
+
+        $this->assertContains(
+            'LOG FILENAME CHANGED VIA PARAMETER:',
+            $commandTester->getDisplay(),
+            'Log filename change was not outputted to console'
+        );
+
+    }
+
 }