Debian packaging patches.

[petterreinholdtsen]

Dear developer,

You might want to have a look at the patches used in the Debian package I just uploaded for NEW approval, https://ftp-master.debian.org/new.html. The patches are available from https://salsa.debian.org/science-team/opencamlib/-/tree/master/debian/patches. I am not sure which ones would be useful to include upstream.

[vespakoen]

Hi Peter!

Thanks for working on this, it is greatly appreciated!

I looked through the patches and here are my thoughts:

1. 0000-disable-git-check.patch We seem to have a lot of code for getting a VERSION_STRING, for which there is already a CMake option, I am thinking we should probably get rid of all of it, and use the -DVERSION_STRING argument to pass something in.
2. 1000-fix-python-paths.patch The "import site; print(site.getsitepackages()[-2])" command is not very portable, for that reason, we got rid of the "automagic site-packages folder finding", you can set CMAKE_INSTALL_PREFIX to a place where you want to install the library, I think I prefer this way more.
   However, it looks like you are using the site-packages path, and got rid of the "opencamlib" postfix, this will probably put the files in the root of site-packages, in stead of in the opencamlib sub-folder. Please double check this!
3. 1010-no-static-boost.patch This should definitely be a CMake option on our side, sorry for forcing static builds on everyone ;)
4. 1011-Fix-doxygen-INPUT-paths-for-out-of-tree-build.patch This will make the Doxyfile only usable through CMake I think? I think I prefer the relative paths, just make sure to run Doxygen from the right folder ;)

[petterreinholdtsen]

[Koen Schmeets]

Thanks for working on this, it is greatly appreciated! I looked through the patches and here are my thoughts: 1) `0000-disable-git-check.patch` We seem to have a lot of code for getting a VERSION_STRING, for which there is already a CMake option, I am thinking we should probably get rid of all of it, and use the -DVERSION_STRING argument to pass something in.

A simpler solution would be most welcome. What about storing the version string in a file and use this value everywhere?

2) `1000-fix-python-paths.patch` The `"import site; print(site.getsitepackages()[-2])"` command is not very portable, for that reason, we got rid of the "automagic site-packages folder finding", you can set `CMAKE_INSTALL_PREFIX` to a place where you want to install the library, I think I prefer this way more. However, it looks like you are using the site-packages path, and got rid of the "opencamlib" postfix, this will probably put the files in the root of site-packages, in stead of in the opencamlib sub-folder. Please double check this!

Right. I'll see if I can get this approach working. Inherited the patching approach from the original packager. I verified the correct subfolder is used already.

3) `1010-no-static-boost.patch` This should definitely be a CMake option on our side, sorry for forcing static builds on everyone ;)

Personally, I believe dynamic build should be the default, to ensure security fixes in dependencies take effect.

4) `1011-Fix-doxygen-INPUT-paths-for-out-of-tree-build.patch` This will make the Doxyfile only usable through CMake I think? I think I prefer the relative paths, just make sure to run Doxygen from the right folder ;)

Well, the 'right folder' is a subfolder when building from a subfolder, and it would be nice if it work out of the box. The issue at hand is that 'mkdir somedir; cd somedir; cmake ...; make' do not work. A subdir is used to make it easy to ensure every generated file is removed when cleaning up the build. PS: Here Peter and Petter are two different names. Peter is my fifth cousin. -- Happy hacking Petter Reinholdtsen

[vespakoen]

Sorry for misspelling your name, that all seems reasonable to me.
I am working on a patch over here:

#158

[petterreinholdtsen]

[Koen Schmeets]

Sorry for misspelling your name, that all seems reasonable to me.

No worries. :)

I am working on a patch over here: #158

Very good. Do you plan to make a new release with this patches any time soon? I would wrap it up and upload it for NEW processing to make sure the latest changes are being reviewed by the archive gatekeepers in Debian. :)

…

-- Happy hacking Petter Reinholdtsen

[petterreinholdtsen]

The opencamlib package was just accepted into Debian, <URL: https://tracker.debian.org/pkg/opencamlib >. Seem to build fine on most archs, <URL: https://buildd.debian.org/status/package.php?p=opencamlib >. -- Happy hacking Petter Reinholdtsen

[petterreinholdtsen]

[Koen Schmeets]

2) `1000-fix-python-paths.patch` The `"import site; print(site.getsitepackages()[-2])"` command is not very portable, for that reason, we got rid of the "automagic site-packages folder finding", you can set `CMAKE_INSTALL_PREFIX` to a place where you want to install the library, I think I prefer this way more. However, it looks like you are using the site-packages path, and got rid of the "opencamlib" postfix, this will probably put the files in the root of site-packages, in stead of in the opencamlib sub-folder. Please double check this!

[Petter Reinholdtsen]

Right. I'll see if I can get this approach working. Inherited the patching approach from the original packager. I verified the correct subfolder is used already.

Apparently my chech was done before the latest changes were applied. The automatic testing of the Debian package exposed that the path was wrong. It has been fixed in the latest edition of 1000-fix-python-paths.patch.

…

-- Happy hacking Petter Reinholdtsen

[petterreinholdtsen]

Version 2023.01.11-4 of the package in Debian has now built on all architectures, is installed by 0.02% of the population and will from today be installed by defaul with FreeCAD in both Debian Unstable and Debian Testing. <URL: https://tracker.debian.org/pkg/opencamlib > got the details. If a new version is released soon, I will package it for Debian. In a while I will have moved on to other projects and it might take some time before I find time to look at opencamlib again. Because of this it would be great for me if a new version of opencamlib was released soon, to get the latest and greatest into Debian.

…

-- Happy hacking Petter Reinholdtsen

[vespakoen]

That's great!
I am working on the develop branch right now so I can test the CD github action. It seems to almost work again now.
Will work on in this week and hope I can get a release out.

[petterreinholdtsen]

[Koen Schmeets]

That's great! I am working on the develop branch right now so I can test the CD github action. It seems to almost work again now. Will work on in this week and hope I can get a release out.

Thank you. The number of Debian installations keep raising, most likely because it is pulled into machines where FreeCAD was already installed, as it is a new dependency for freecad in Debian. Btw, is the library in active development getting new CAM features, or just in maintenance mode? <URL: https://openhub.net/p/opencamlib > do not present a clear picture. Also, is <URL: www.anderswallin.net/CAM > the project home page or is it not updated there any more?

…

-- Happy hacking Petter Reinholdtsen

[vespakoen]

I would say the library is in maintenance mode.
But it is the only library of it's kind (afaik).
I tried to make the compilation / installation a bit easier by providing precompiled libraries and added a nodejs and emscripten module so it can be used in JavaScript.
The core functionality didn't change.

The homepage is correct. It contains the most information about the algo's.

Api docs are over here: https://opencamlib.readthedocs.io/en/latest/api.html

[petterreinholdtsen]

Hi. Any news on making a new opencamlib release? It would make life easier for Debian package maintainers to have a stamped version.

…

-- Happy hacking Petter Reinholdtsen

[vespakoen]

Hi Peter,

I think I got pretty far with these fixes and it got kinda stuck on a single failing windows build which i was unable to resolve, after that, a startup i worked for got merged with another company and things got pretty busy over here with other things, I cannot promise anything but I will try to take another stab at this next week.

[petterreinholdtsen]

[Koen Schmeets]

I cannot promise anything but I will try to take another stab at this next week.

Did you have any success that week, or any of the following weeks? -- Happy hacking Petter Reinholdtsen

[petterreinholdtsen]

How is the integration of the Debian patches coming along?

…

-- Happy hacking Petter Reinholdtsen

[petterreinholdtsen]

I just updated the Debian package of opencamlib. How is the new upstream release coming along? -- Happy hacking Petter Reinholdtsen