Skip to content

Commit 299904d

Browse files
committed
Add explaining comment on why we, uncessarily, repack standard library packs
1 parent a846a84 commit 299904d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

codeql_bundle/helpers/bundle.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,9 @@ def add_to_graph(pack: ResolvedCodeQLPack, processed_packs: set[ResolvedCodeQLPa
296296
logger.debug(f"Adding stdlib dependency {std_lib_dep.config.name}@{str(std_lib_dep.config.version)} to {pack.config.name}@{str(pack.config.version)}")
297297
pack.dependencies.append(std_lib_dep)
298298
logger.debug(f"Adding pack {pack.config.name}@{str(pack.config.version)} to dependency graph")
299+
# We include standard library packs in the dependency graph to ensure they dictate the correct order
300+
# when we need to customize packs.
301+
# This does mean we will repack them, but that is only small price to pay for simplicity.
299302
pack_sorter.add(pack, *pack.dependencies)
300303
for dep in pack.dependencies:
301304
if dep not in processed_packs:

0 commit comments

Comments
 (0)