Skip to content

Subtitles being handled incorrectly by translator #55

@seasidesparrow

Description

@seasidesparrow

The translator is currently written to assume that the contents of the subtitle element are a string, but they should actually be treated like an object of type Title.json. When ManualParser tries to write a classic record for an input file having a subtitle specified, it will generate a failure about being unable to concatenate a variable of type dict to a string, which happens when the subtitle is appended to the title.

To fix, instead of passing the subtitle object from the parser, in translator, pass sub_title.get("textEnglish", "")

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions