Refocus app shell tests on frontend contracts#93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_app_shell.pywith parsed element/attribute contract checks#67baseline of about25sto12.54son this branchWhy
The app-shell tests were over-specifying incidental markup, CSS, and JS source strings. That made small frontend refactors look risky without proving much user-facing behavior. This keeps the important contracts covered while moving behavior assertions into runtime-style frontend tests where possible.
This also addresses the test-suite runtime problem from
#67: the suite is now materially faster while preserving the behavior coverage that matters.Testing
uv run pytest tests/test_app_shell.py tests/test_app_frontend.py tests/test_probe_frontend.py -quv run ruff check tests/test_app_shell.py tests/test_app_frontend.py tests/test_probe_frontend.pyuv run ty check tests/test_app_shell.py tests/test_app_frontend.py tests/test_probe_frontend.pyuv run pytest(166 passed in 12.54s)Closes #67