Skip to content

Commit 08c778c

Browse files
committed
update readme static check and beforeach
1 parent 7bc2665 commit 08c778c

6 files changed

Lines changed: 12 additions & 11 deletions

File tree

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,9 @@ Use Playwright's [Fixtures feature](https://playwright.dev/docs/test-fixtures) f
9696
Example:
9797

9898
```typescript
99-
test("Add new entry on home page", async ({ page, homePage, testData }) => {
99+
test("Add new entry on home page", async ({ page, testData }) => {
100100
await page.goto("/");
101-
await homePage.developerInputField().fill("dev");
102-
await homePage.secretKeyInputField().fill(testData.secretKey);
101+
await page.getByTestId(secretKeyInputField).fill(testData.secretKey);
103102
});
104103
```
105104

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"main": "",
55
"type": "module",
66
"scripts": {
7-
"static-checks": "npx eslint . && npx tsc --noEmit",
7+
"static-checks": "npm run clean-reports && npx eslint . && npx tsc --noEmit",
88
"regression": "npm run static-checks && npx playwright test --grep @regression",
99
"runAll": "npm run clean-reports && npm run static-checks && npx playwright test",
1010
"allure-report-single": "npx allure generate --single-file --clean",

tests/homePage.spec.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,19 +16,20 @@ const addNewEntryBtn = "new-entry-submit-btn";
1616
const successfulEntryAddedMsg = "info-msg-entry-added";
1717

1818
test.describe("Home Page Verifications", () => {
19+
test.beforeEach(async ({ page }) => {
20+
await page.goto("/");
21+
});
22+
1923
test(
2024
"Verify cards are loaded on home page",
2125
{ tag: "@regression" },
2226
async ({ page }) => {
23-
await page.goto("/");
2427
await expect(page.getByText("Loading...")).not.toBeVisible();
2528
await expect(page.getByTestId(cardId).first()).toBeVisible();
2629
}
2730
);
2831

2932
test("Add new entry on home page", async ({ page, testData }) => {
30-
await page.goto("/");
31-
3233
await test.step("Fill the form", async () => {
3334
await page.getByTestId(developerInput).fill(generateRandomString(6));
3435
await page.getByTestId(qaInputField).fill(faker.person.firstName());

tests/teamPage.spec.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@ const viewTeamBtn = "view-task-btn";
44
const developerInfo = "developer-info";
55

66
test.describe("Team Page", () => {
7-
test("Verify team page", async ({ page }) => {
7+
test.beforeEach(async ({ page }) => {
88
await page.goto("/");
9+
});
10+
11+
test("Verify team page", async ({ page }) => {
912
await page.getByTestId(viewTeamBtn).first().click();
1013
await expect(page.getByTestId(developerInfo)).toContainText("Developer");
1114
});
1215

1316
test("Intentional fail test", async ({ page }) => {
14-
await page.goto("/");
1517
await page.getByTestId(viewTeamBtn).click();
1618
await expect(page.getByTestId(viewTeamBtn).first()).toBeVisible();
1719
});

utils/fixWithAi.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ function buildPrompt({
7272
* See: https://github.com/microsoft/playwright/blob/release-1.49/packages/playwright/src/reporters/base.ts#L491
7373
*/
7474
function stripAnsiEscapes(str: string): string {
75-
// eslint-disable-next-line max-len, no-control-regex
7675
const ansiRegex = new RegExp(
7776
"([\\u001B\\u009B][[\\]()#;?]*(?:(?:(?:[a-zA-Z\\d]*(?:;[-a-zA-Z\\d\\/#&.:=?%@~_]*)*)?\\u0007)|(?:(?:\\d{1,4}(?:;\\d{0,4})*)?[\\dA-PR-TZcf-ntqry=><~])))",
7877
"g"

utils/reportsCleanup.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ const cleanFolder = async (folderPath) => {
1515
console.log(
1616
`${path.basename(
1717
folderPath
18-
)} folder does not exist, skipping initial cleanup`
18+
)} folder does not exist, skipping cleanup for this folder`
1919
);
2020
} else {
2121
console.error(

0 commit comments

Comments
 (0)