Skip to content

Commit 0645caf

Browse files
author
Alastair Choo
committed
clamp picker value height
1 parent eabc625 commit 0645caf

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

packages/@react-spectrum/s2/src/Picker.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,8 @@ const valueStyles = style({
233233
},
234234
truncate: true,
235235
display: 'flex',
236-
alignItems: 'center'
236+
alignItems: 'center',
237+
maxHeight: '100%'
237238
});
238239

239240
const iconStyles = style({
@@ -543,7 +544,6 @@ const PickerButton = createHideableComponent(function PickerButton<T extends obj
543544
<SelectValue
544545
className={
545546
valueStyles({isQuiet}) +
546-
// Might be ok?
547547
(renderValue ? '' : ' ' + raw('&> :not([slot=icon], [slot=avatar], [slot=label], [data-slot=label]) {display: none;}'))
548548
}>
549549
{({selectedItems, defaultChildren}) => {

packages/@react-spectrum/s2/stories/Picker.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ export const CustomRenderValue: StoryObj<CustomRenderValuePickerStoryType> = {
362362
renderValue: (selectedItems) => (
363363
<div style={{display: 'flex', gap: 4}}>
364364
{selectedItems.map(item => (
365-
<Avatar slot="avatar" key={item.id} src={item.icon} />
365+
<img key={item.id} src={item.icon} alt={item.label} />
366366
))}
367367
</div>
368368
)

0 commit comments

Comments
 (0)