Skip to content

Correct keywords for table/feature blocks#1833

Open
signalwerk wants to merge 1 commit into
adobe-type-tools:developfrom
signalwerk:fix-keywords
Open

Correct keywords for table/feature blocks#1833
signalwerk wants to merge 1 commit into
adobe-type-tools:developfrom
signalwerk:fix-keywords

Conversation

@signalwerk
Copy link
Copy Markdown

The following keywords were missing from the list (but specified in the corresponding table/feature):

  • nameid
  • FSType
  • name
  • WeightClass
  • WidthClass
  • LowerOpSize
  • UpperOpSize
  • FamilyClass

The sorting of the keywords in the list was also not consistent (not alphabetical by keyword, not alphabetical by table/feature name, almost order of appearance in the specification). It is now sorted by the order of appearance in the specification (8.b, 9.a, 9.b, …).

@frankrolf
Copy link
Copy Markdown
Member

Thank you for the update! Seems reasonable :-)

I’m curious – have you tested if these keywords have the intended effect when compiling a font?

    LowerOpSize <number>;
    UpperOpSize <number>;
    FamilyClass <number>;

Thanks again!

@signalwerk
Copy link
Copy Markdown
Author

@frankrolf Thank you for your reply. I was not testing this. I was working on a .fea syntax highlighter and I just realized the inconsistency in the documentation. Because it was not otherwise mentioned and the documentation implies it is working, I mentioned it as implemented.

@frankrolf
Copy link
Copy Markdown
Member

@signalwerk I hope you are aware of this: https://gitlab.com/saalen/highlight

I recently contributed .fea support to this package.

@signalwerk
Copy link
Copy Markdown
Author

@frankrolf thank you for pointing that out. I use support in highlightjs but it's good to have your implementation. Great!

@skef skef added the fea spec label May 21, 2026
@skef
Copy link
Copy Markdown
Collaborator

skef commented May 21, 2026

Given the timing this should go through the https://github.com/adobe-type-tools/feature_file_workshops process. @signalwerk do you have any interest in doing a PR over there, or would you like us to? Either is fine -- this is less of a change than just clean-up and therefore cosmically on us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants