incorrect structure generated for some products

[sirugh]

Issue Description

A product, adb266, is not rendering with correct structure markup from the renderer, while another product is, adb407.

I deleted adb266 content via helix api, then re-ran the poller to attempt to re-generate. I also tried deleting it and manually previewing/publishing the product from the helix api.

Also, it appears the generated azure html is wrong for adb266 - the structure is different.

Investigation Details

includes blocks/classnames in final helix markup 👍🏼

• Product: adb407 (ecycled-performance-hat2)
• Site URL: https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/ecycled-performance-hat2/adb407
• Plain HTML: https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/ecycled-performance-hat2/adb407.plain.html
• Overlay Source: https://firefly.azureedge.net/a2496cffffd20d3361b8d3698449049f-public/public/pdps/products/ecycled-performance-hat2/adb407.html
• HLX Status: https://admin.hlx.page/status/adobe-commerce/plp-prerender-dev/main/products/ecycled-performance-hat2/adb407

does not include blocks/classnames in final helix markup 👎🏼

• Product: adb266 (adobe-premiere-pro-tee)
• Site URL: https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/adobe-premiere-pro-tee/adb266
• Plain HTML: https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/adobe-premiere-pro-tee/adb266.plain.html
• Overlay Source: https://firefly.azureedge.net/a2496cffffd20d3361b8d3698449049f-public/public/pdps/products/adobe-premiere-pro-tee/adb266.html
• HLX Status: https://admin.hlx.page/status/adobe-commerce/plp-prerender-dev/main/products/adobe-premiere-pro-tee/adb266

More examples

Working:

• https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/ssg-configurable-product/ssgconfig123
• https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/adobe-pattern-hoodie/adb127
• https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/adobe-for-all-pin/adb343

Not Working:

• https://products-ssg--plp-prerender-dev--adobe-commerce.aem.live/products/tray-art-by-emma-zhang/adb412

[sirugh]

Interestingly - the azure html is slightly different!

Notice on the left, the "invalid" product has a div under main around product-details, but not the other blocks, whereas the "valid" product has all blocks at the same level in the DOM.

[sirugh]

Even stranger - the adb412 product is also incorrect, but the other blocks are being nested within product details for some reason.

[sirugh]

Ok - it turns out that this is happening because the product data itself was malformed. Random products had bad descriptions - that is, some with open tags only. Some with closing tags. When these are found, the result is the handlebars compilation output can be wildly different.

This is not really a problem of the renderer, but I do think we should log warnings when malformed HTML is found.