Selecting rows and footer action issues/improvements

[adrianbj]

I don't know how much effort should be put into this or even if I am overlooking something on some of these, but these seem a bit weird to me.

1. Selecting a row (edit checkbox), or checking the "whole result" checkbox highlights the Save button, but what is there to save at this point - no changes have been made, right?

2. If you don't have any rows selected, the edit and clone buttons are still active, and if you click them, it looks a bit like the new item dialog, but then nothing is added when you save. Maybe these buttons could be disabled unless a row is selected.

3. Similar issue to 2 - if you have selected more than one row, the edit and clone buttons are still active, but bring up that same dialog that doesn't seem to do anything. I think they should be disabled in all situations unless one single row is selected.

4. The delete button should also be disabled unless at least one row is selected. At the moment you get a confirmation dialog but then it shows no rows affected (which of course there isn't because none were selected).

5. This one isn't in the footer, but I wonder if disabling (and greying out) of the option that is currently active would make sense for these. I know the active one is bold, but I think it's not that obvious and greying/disabling would be clearer IMO.

[peterpp]

ad 1) I want to remove the dynamic highlighting of the default submit button. It is highlighted when the focus is in any form input and you are able to submit the form with the Enter key. In my opinion, this is unexpected and unnecessary behavior.

[vrana]

1. You can edit a value by Ctrl+click and then save but you are right that it makes no sense to highlight this button. If you click it then it will tell you what to do, that's why it isn't disabled.

2. This is actually a power feature of Adminer - you can edit more rows at the same time - either set some column to a new value or even do relative operations like rank = rank + 1.

3. I use this link to reload the page, clear the filters and similar.

The other suggestions make perfect sense, thanks.

[vrana]

2 and 4 work like you would expect in original Adminer for ages. Perhaps AdminNeo broke it.

[peterpp]

ad 1) Dynamic highlighting of the default submit button based on the focus has already been removed in v5. I would like to highlight Save button if some values are in inline edit mode.

ad 2) and 4) Disabling buttons Edit/Clone/Delete is fixed.

ad 3) As @vrana mentioned, you can multi edit/clone more selected rows at once.

ad 5) I agree that top links can be improved. But I would go with highlighting of the active link, not graying it – to be more consistent with the left menu.