EXC_BAD_ACCESS +[ADJUtil writeObject:fileName:objectName:syncObject:]

[makleso6]

I have a crash

devices:
iPad Pro 12.9 inch 5th Gen - 46,31 %
iPhone X - 23,01 %
iPhone XR - 11,21 %
iPhone 8 Plus - 10,91 %
iPhone 7 Plus - 3,83 %

OS Versions:
iOS 26.2 -25,22 %
iOS 26.2.1 -22,71 %
iOS 16.7.11 -18,44 %
iOS 16.7.12 -13,27 %
iOS 17.5.1 -4,72 %

about 1700 crashes per month

EXC_BAD_ACCESS 0x0000000000000001

Crashed: Thread
0  CoreFoundation           _CFArrayReplaceValues + 1000
1  CoreFoundation           _CFArrayReplaceValues + 944
2  CoreFoundation           CFArrayAppendValue + 148
3  CoreFoundation           _flattenPlist + 272
4  CoreFoundation           _flattenPlist + 644
5  CoreFoundation           _flattenPlist + 744
6  CoreFoundation           _flattenPlist + 644
7  CoreFoundation           __CFBinaryPlistWriteOrPresize + 236
8  Foundation               -[NSKeyedArchiver finishEncoding] + 520
9  Foundation               -[NSKeyedArchiver encodedData] + 64
10 Foundation               +[NSKeyedArchiver archivedDataWithRootObject:requiringSecureCoding:error:] + 96
11 Edadeal                  +[ADJUtil writeObject:fileName:objectName:syncObject:] + 168
12 Edadeal                  -[ADJPackageHandler writePackageQueueS:] + 124
13 Edadeal                  -[ADJPackageHandler addI:package:] + 444
14 Edadeal                  __42+[ADJUtil launchInQueue:selfInject:block:]_block_invoke + 48
15 libdispatch.dylib        _dispatch_call_block_and_release + 24
16 libdispatch.dylib        _dispatch_client_callout + 16
17 libdispatch.dylib        _dispatch_lane_serial_drain$VARIANT$armv81 + 600
18 libdispatch.dylib        _dispatch_lane_invoke$VARIANT$armv81 + 380
19 libdispatch.dylib        _dispatch_workloop_worker_thread + 608
20 libsystem_pthread.dylib  _pthread_wqthread + 284

EXC_BREAKPOINT 0x0000000000000001

Crashed: Thread
0  CoreFoundation           __CFBasicHashRehash + 104
1  CoreFoundation           __CFBasicHashRehash + 208
2  CoreFoundation           __CFBasicHashAddValue + 104
3  CoreFoundation           CFBasicHashAddValue + 1988
4  CoreFoundation           CFDictionaryAddValue + 228
5  CoreFoundation           _flattenPlist + 288
6  CoreFoundation           _flattenPlist + 644
7  CoreFoundation           _flattenPlist + 744
8  CoreFoundation           _flattenPlist + 644
9  CoreFoundation           __CFBinaryPlistWriteOrPresize + 236
10 Foundation               -[NSKeyedArchiver finishEncoding] + 520
11 Foundation               +[NSKeyedArchiver archivedDataWithRootObject:requiringSecureCoding:error:] + 112
12 Edadeal                  +[ADJUtil writeObject:fileName:objectName:syncObject:] + 168
13 Edadeal                  -[ADJPackageHandler writePackageQueueS:] + 124
14 Edadeal                  -[ADJPackageHandler sendNextI:previousResponseContinueIn:] + 148
15 Edadeal                  __37-[ADJPackageHandler sendNextPackage:]_block_invoke + 64
16 Edadeal                  __42+[ADJUtil launchInQueue:selfInject:block:]_block_invoke + 48
17 libdispatch.dylib        _dispatch_call_block_and_release + 24
18 libdispatch.dylib        _dispatch_client_callout + 16
19 libdispatch.dylib        _dispatch_lane_serial_drain$VARIANT$armv81 + 600
20 libdispatch.dylib        _dispatch_lane_invoke$VARIANT$armv81 + 380
21 libdispatch.dylib        _dispatch_workloop_worker_thread + 608
22 libsystem_pthread.dylib  _pthread_wqthread + 284

EXC_BREAKPOINT 0x0000000000000001

Crashed: Thread
0  CoreFoundation           __CFBasicHashRehash + 100
1  CoreFoundation           __CFBasicHashRehash + 212
2  CoreFoundation           __CFBasicHashAddValue + 100
3  CoreFoundation           CFDictionarySetValue + 208
4  Foundation               _encodeObject + 656
5  Foundation               -[NSKeyedArchiver _encodeArrayOfObjects:forKey:] + 460
6  Foundation               -[NSDictionary(NSDictionary) encodeWithCoder:] + 564
7  Foundation               _encodeObject + 1176
8  Edadeal                  -[ADJActivityPackage encodeWithCoder:] + 280
9  Foundation               _encodeObject + 1176
10 Foundation               -[NSKeyedArchiver _encodeArrayOfObjects:forKey:] + 460
11 Foundation               -[NSArray(NSArray) encodeWithCoder:] + 584
12 Foundation               _encodeObject + 1176
13 Foundation               +[NSKeyedArchiver archivedDataWithRootObject:requiringSecureCoding:error:] + 88
14 Edadeal                  +[ADJUtil writeObject:fileName:objectName:syncObject:] + 168
15 Edadeal                  -[ADJPackageHandler writePackageQueueS:] + 124
16 Edadeal                  -[ADJPackageHandler sendNextI:previousResponseContinueIn:] + 148
17 Edadeal                  __37-[ADJPackageHandler sendNextPackage:]_block_invoke + 64
18 Edadeal                  __42+[ADJUtil launchInQueue:selfInject:block:]_block_invoke + 48
19 libdispatch.dylib        _dispatch_call_block_and_release + 32
20 libdispatch.dylib        _dispatch_client_callout + 16
21 libdispatch.dylib        _dispatch_lane_serial_drain + 740
22 libdispatch.dylib        _dispatch_lane_invoke + 388
23 libdispatch.dylib        _dispatch_root_queue_drain_deferred_wlh + 292
24 libdispatch.dylib        _dispatch_workloop_worker_thread + 540
25 libsystem_pthread.dylib  _pthread_wqthread + 292

[makleso6]

Possible fix

- (void)writePackageQueueS:(ADJPackageHandler *)selfS {
    if (selfS.packageQueue == nil) {
        return;
    }
    
    [ADJUtil writeObject:[selfS.packageQueue copy] // Use copy
                fileName:kPackageQueueFilename
              objectName:@"Package queue"
              syncObject:[ADJPackageHandler class]];
}

- (void)writeActivityStateI:(ADJActivityHandler *)selfI
{
    [ADJUtil launchSynchronisedWithObject:[ADJActivityState class]
                                    block:^{
        if (selfI.activityState == nil) {
            return;
        }
        [ADJUtil writeObject:[selfI.activityState copy] // Use copy
                    fileName:kActivityStateFilename
                  objectName:@"Activity state"
                  syncObject:[ADJActivityState class]];
    }];
}

- (void)writeAttributionI:(ADJActivityHandler *)selfI {
    @synchronized ([ADJAttribution class]) {
        if (selfI.attribution == nil) {
            return;
        }
        [ADJUtil writeObject:[selfI.attribution copy] // Use copy
                    fileName:kAttributionFilename
                  objectName:@"Attribution"
                  syncObject:[ADJAttribution class]];
    }
}

- (void)writeGlobalCallbackParametersI:(ADJActivityHandler *)selfI {
    @synchronized ([ADJGlobalParameters class]) {
        if (selfI.globalParameters == nil) {
            return;
        }
        [ADJUtil writeObject:[selfI.globalParameters.callbackParameters copy] // Use copy
                    fileName:kGlobalCallbackParametersFilename
                  objectName:@"Global Callback parameters"
                  syncObject:[ADJGlobalParameters class]];
    }
}

- (void)writeGlobalPartnerParametersI:(ADJActivityHandler *)selfI {
    @synchronized ([ADJGlobalParameters class]) {
        if (selfI.globalParameters == nil) {
            return;
        }
        [ADJUtil writeObject:[selfI.globalParameters.partnerParameters copy] // Use copy
                    fileName:kGlobalPartnerParametersFilename
                  objectName:@"Global Partner parameters"
                  syncObject:[ADJGlobalParameters class]];
    }
}

[uerceg]

Hey @makleso6,

Thanks for the report. We have been working on this on our end in the meantime and will try to ship an SDK update soon in the attempt to address this. Will keep you posted.

[makleso6]

Hi, @uerceg thank you for the update! Could you please let me know if this issue has been addressed in the latest release? I'd like to know if it's safe to update.

[uerceg]

Hey @makleso6,

Thanks for the ping and sorry for the delay on our end. We have just shipped v5.5.4 where this issue has been attempted to be addressed. Please, give it a shot and let us know if you are still observing the same issue or not. Looking forward to hearing back from you.

Cheers

[anwarhssine]

Hi @uerceg,

We’re seeing this crash on the React Native SDK. Since it was fixed on the iOS side, will this fix be coming to the React Native SDK as well?

[uerceg]

Hi @anwarhssine,

Most probably during the next week. Keep an eye on react_native_sdk repo releases.

[anwarhssine]

Awesome, thank you @uerceg !

[gfx]

Happning with Adjust SDK 5.6.0 (iOS).

[uerceg]

@gfx Can you please provide example stack traces from the crashes that you have experienced with the v5.6.0?