File tree Expand file tree Collapse file tree
java/org/prebid/server/bidder/oms
test/java/org/prebid/server/bidder/oms Expand file tree Collapse file tree Original file line number Diff line number Diff line change 3232
3333public class OmsBidder implements Bidder <BidRequest > {
3434
35+ private static final String PUBLISHER_ID_MACRO = "{{PublisherId}}" ;
3536 private static final TypeReference <ExtPrebid <?, ExtImpOms >> EXT_TYPE_REFERENCE = new TypeReference <>() {
3637 };
38+
3739 private final String endpointUrl ;
3840 private final JacksonMapper mapper ;
3941
@@ -48,7 +50,7 @@ public Result<List<HttpRequest<BidRequest>>> makeHttpRequests(BidRequest request
4850 final ExtImpOms impExt = parseImpExt (request .getImp ().getFirst ());
4951 final String publisherId = resolverPublisherId (impExt .getPid (), impExt .getPublisherId ());
5052 final String encodedPublisherId = HttpUtil .encodeUrl (publisherId );
51- final String url = "%s?publisherId=%s" . formatted ( endpointUrl , encodedPublisherId );
53+ final String url = endpointUrl . replace ( PUBLISHER_ID_MACRO , encodedPublisherId );
5254 return Result .withValue (BidderUtil .defaultRequest (request , url , mapper ));
5355 } catch (PreBidException e ) {
5456 return Result .withError (BidderError .badInput (e .getMessage ()));
Original file line number Diff line number Diff line change 11adapters :
22 oms :
3- endpoint : http://rt.marphezis.com/pbs
3+ endpoint : http://rt.marphezis.com/pbs?pid={{PublisherId}}
44 meta-info :
55 maintainer-email : prebid@onlinemediasolutions.com
66 app-media-types :
Original file line number Diff line number Diff line change 3535
3636public class OmsBidderTest extends VertxTest {
3737
38- private static final String ENDPOINT_URL = "https://randomurl.com" ;
38+ private static final String ENDPOINT_URL = "https://randomurl.com?pid={{PublisherId}} " ;
3939
4040 private final OmsBidder target = new OmsBidder (ENDPOINT_URL , jacksonMapper );
4141
@@ -70,7 +70,7 @@ public void makeHttpRequestsShouldCreateExpectedUrl() {
7070 assertThat (result .getErrors ()).isEmpty ();
7171 assertThat (result .getValue ()).hasSize (1 )
7272 .extracting (HttpRequest ::getUri )
73- .containsExactly ("https://randomurl.com?publisherId =otherTagId" );
73+ .containsExactly ("https://randomurl.com?pid =otherTagId" );
7474 }
7575
7676 @ Test
@@ -86,7 +86,7 @@ public void makeHttpRequestsShouldCreateExpectedUrlWithPublisherId() {
8686 assertThat (result .getErrors ()).isEmpty ();
8787 assertThat (result .getValue ()).hasSize (1 )
8888 .extracting (HttpRequest ::getUri )
89- .containsExactly ("https://randomurl.com?publisherId =12345" );
89+ .containsExactly ("https://randomurl.com?pid =12345" );
9090 }
9191
9292 @ Test
You can’t perform that action at this time.
0 commit comments