feat: ensure validation fails if parameters aren't bound (#179)

Closes #177.

Author: lidavidm

adbc_drivers_validation/model.py

@@ -132,6 +132,9 @@ class DriverFeatures(BaseModel):
     # Some databases support temporary tables, but they exist in the same
     # namespace as regular tables, so we need to change how we test them.
     quirk_bulk_ingest_temporary_shares_namespace: bool = Field(default=False)
+    # Certain checks that are not strictly required by the spec, but which we
+    # expect drivers developed by the foundry directly to conform to
+    quirk_foundry: bool = Field(default=True)
     # Some vendors sort the columns, so declaring FOREIGN KEY(b, a) REFERENCES
     # foo(d, c) still gets returned in the order (a, c), (b, d)
     quirk_get_objects_constraints_foreign_normalized: bool = Field(default=False)

adbc_drivers_validation/tests/ingest.py

@@ -49,6 +49,7 @@ def generate_tests(
     for quirks in all_quirks:
         driver_param = f"{quirks.name}:{quirks.short_version}"
         enabled = {
+            "test_ingest_no_parameters": quirks.features.statement_bulk_ingest,
             "test_not_null": quirks.features.statement_bulk_ingest,
             "test_schema": quirks.features.statement_bulk_ingest_schema,
             "test_catalog": quirks.features.statement_bulk_ingest_catalog,
@@ -859,6 +860,31 @@ def test_many_columns(
             assert result is not None
             assert result[0] == num_rows
 
+    def test_ingest_no_parameters(
+        self,
+        driver: model.DriverQuirks,
+        conn: adbc_driver_manager.dbapi.Connection,
+    ) -> None:
+        # Ensure ingest works without parameters bound
+        table_name = "test_ingest_no_parameters"
+        with conn.cursor() as cursor:
+            cursor.adbc_statement.set_options(
+                **{
+                    adbc_driver_manager.StatementOptions.INGEST_TARGET_TABLE.value: table_name,
+                }
+            )
+            with pytest.raises(adbc_driver_manager.dbapi.Error) as excinfo:
+                cursor.adbc_statement.execute_update()
+
+            if driver.features.quirk_foundry:
+                assert (
+                    excinfo.value.status_code
+                    == adbc_driver_manager.AdbcStatusCode.INVALID_STATE
+                )
+                assert isinstance(
+                    excinfo.value, adbc_driver_manager.dbapi.ProgrammingError
+                )
+
     def test_ingest_then_query(
         self,
         driver: model.DriverQuirks,