-
-
Notifications
You must be signed in to change notification settings - Fork 112
add URLSearchParams::to_unsafe_string() method #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: yagiz/add-to-raw-string
Are you sure you want to change the base?
Conversation
|
@copilot can you also make sure the documentation reflects this: /**
|
Co-authored-by: anonrig <1935246+anonrig@users.noreply.github.com>
|
@copilot make sure lint and format ci job passes |
Co-authored-by: anonrig <1935246+anonrig@users.noreply.github.com>
Co-authored-by: anonrig <1935246+anonrig@users.noreply.github.com>
Fixed clang-format issues in 94c3a8f. The lint/format CI should pass now.
The documentation already reflects that exact format - lines 103-108 in |
|
I am not against this change, but I think it will not solve the issue in its current form: See: #1023 (comment) The expected use from our side is to feed ada search params with some standard (w3c/rfc/mixed) or with small amount of deviation from them, and then do non-destructive changes to it, for example removal of a single parameter (meaning rest should be treated as normal, if someone replaces existing parameter, it is fine to do it normal ada w3c way, but again, not touch any other parameter). The problem is that once query is fed to ada, it gets decoded and that process loses original information as multiple values may decode to same decoded value. With some of our customers this causes unexpected behavior. The first issue we got reported was that when we removed one parameter, the |
| @@ -0,0 +1 @@ | |||
| . No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't push this file
to_unsafe_string()method for URLSearchParamsada_search_params_to_unsafe_stringto_raw_stringtoto_unsafe_stringper reviewer feedback✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.