Upgrade `moduleResolution` from `node` to `node16` or `nodenext` in tsconfig

[caleblloyd]

The tsconfig.json currently uses moduleResolution: node

languageservices/languageserver/tsconfig.json

Line 10 in bdee101

"moduleResolution": "node",

This should no longer be used in TypeScript:

It reflects the CommonJS module resolution algorithm as it existed in Node.js versions earlier than v12. It should no longer be used.

I think this is causing errors when importing as an NPM module from Deno, because imports should specify extensions, yet they do not with this module resolution

And the package.json specifies that this is an esmodule:

languageservices/languageservice/package.json

Line 6 in bdee101

"type": "module",

Consider moving it to node16 or nodenext

[potor10]

Do we know why this PR was closed?
As far as I can tell, adding file extensions is the standard and is enforced in node16 / nodenext.

I agree with Caleb here, given the fact that node10 is clearly deprecated, we should be trying to upgrade to node16.
Fixing this issue will also address other issues which are currently opened on this repo:

• Published ESM code has imports without file extensions #110
• expressions: ERR_MODULE_NOT_FOUND attempting to run example demo script #64

I actually ran a test with #64, and I can confirm that rebuilding under "moduleResolution": "node16" actually completely resolved the issue for the expression engine.

Clean Install with npm ci

C:\Users\peteliu\Documents\Dev\expression-test> node .\src\index.mjs
node:internal/modules/esm/resolve:275
    throw new ERR_MODULE_NOT_FOUND(
          ^

Error [ERR_MODULE_NOT_FOUND]: Cannot find module 'C:\Users\peteliu\Documents\Dev\expression-test\node_modules\@actions\expressions\dist\ast' imported from C:\Users\peteliu\Documents\Dev\expression-test\node_modules\@actions\expressions\dist\index.js
    at finalizeResolution (node:internal/modules/esm/resolve:275:11)
    at moduleResolve (node:internal/modules/esm/resolve:860:10)
    at defaultResolve (node:internal/modules/esm/resolve:984:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:685:12)
    at #cachedDefaultResolve (node:internal/modules/esm/loader:634:25)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:617:38)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:273:38)
    at ModuleJob._link (node:internal/modules/esm/module_job:135:49) {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///C:/Users/peteliu/Documents/Dev/expression-test/node_modules/@actions/expressions/dist/ast'
}

Replaced with self-built dist

C:\Users\peteliu\Documents\Dev\expression-test> node .\src\index.mjs
false

For me myself, I have also been seeing similar issues with loading the package. In my case, I can load the package except for the completion and funcs imports, as there is a naming collision against the directories with the same name. I can personally vouch that bumping the moduleResolution has resolved my issues as well.

I'm willing to take a shot on porting over the moduleResolution configuration to node16 if nobody else has already started work.

[caleblloyd]

I did get it working in a fork: code-cargo@077fb2b

However it uses higher TypeScript and Node versions than this repo currently supports:

• TypeScript 5.x "moduleResolution": "bundler" (this repo is on TS 4.x)
• NodeJS 20.x Import Attribute (this repo supports 16.x and up)

The fork works in Deno, and I am assuming it works fine in NodeJS 20.x+ also. But since repo is packaged into a VSCode Extension somewhere, I assume there is a minimum NodeJS version support requirement. So I didn't want to open that commit as a PR, since I am not sure that this repo could move from Node 16.x+ to Node 20.x+

There may be some other way to import the JSON files that would avoid the need to upgrade to NodeJS 20.x+. I am assuming the TypeScript 5.x upgrade would be OK.

[potor10]

Sweet, thanks for the update Caleb. Glad that you got it working.
And yeah, it does make sense that upgrading to Node 20 would require a second look. Especially since it's quite a major bump.

On my local fork. I have it configured without a bump in the Node version:

• "moduleResolution": "node16"
• TypeScript 5.7.x "rewriteRelativeImportExtensions": true enabled.
• Updated all imports to use file ext

That being said, I still need to add extensions for every import, because of the "moduleResolution": "node16"
But because the imports are using .ts extensions, it should be compatible with Deno.

[scriptcoded]

I temporarily worked around this by (and don't judge me) simply copying the source code into mine and fixing the import errors. I'll keep a close eye on these issues 🙈