Fix a rendering issue in the dependency details view #1177 (#1178)

Signed-off-by: tdruez <tdruez@nexb.com>

Author: tdruez

CHANGELOG.rst

@@ -7,6 +7,10 @@ v34.5.0 (unreleased)
 - Display the current path location in the "Codebase" panel as a navigation breadcrumbs.
   https://github.com/nexB/scancode.io/issues/1158
 
+- Fix a rendering issue in the dependency details view when for_package or
+  datafile_resource fields do not have a value.
+  https://github.com/nexB/scancode.io/issues/1177
+
 v34.4.0 (2024-04-22)
 --------------------
 

scanpipe/templates/scanpipe/tabset/field_datafile_resource.html

@@ -1 +1 @@
-<pre class="break-all wrap is-small"><a href="{% url 'resource_detail' project.slug field_data.value.path %}">{{ field_data.value|default:''|default_if_none:'' }}</a></pre>
+<pre class="break-all wrap is-small">{% if field_data.value %}<a href="{% url 'resource_detail' project.slug field_data.value.path %}">{{ field_data.value }}</a>{% endif %}</pre>

scanpipe/templates/scanpipe/tabset/field_for_package.html

@@ -1 +1 @@
-<pre class="break-all wrap is-small"><a href="{% url 'package_detail' project.slug field_data.value.uuid %}" title="{{ field_data.value.package_uid }}">{{ field_data.value|default:''|default_if_none:'' }}</a></pre>
+<pre class="break-all wrap is-small">{% if field_data.value %}<a href="{% url 'package_detail' project.slug field_data.value.uuid %}" title="{{ field_data.value.package_uid }}">{{ field_data.value }}</a>{% endif %}</pre>

scanpipe/tests/test_views.py

@@ -1023,12 +1023,13 @@ def test_scanpipe_views_discovered_dependency_views(self):
         dep1 = DiscoveredDependency.create_from_data(self.project1, dependency_data1)
         DiscoveredDependency.create_from_data(self.project1, dependency_data2)
 
-        url = reverse("project_dependencies", args=[self.project1.slug])
+        list_view_url = reverse("project_dependencies", args=[self.project1.slug])
         with self.assertNumQueries(10):
-            self.client.get(url)
+            self.client.get(list_view_url)
 
+        details_url = dep1.get_absolute_url()
         with self.assertNumQueries(6):
-            self.client.get(dep1.get_absolute_url())
+            self.client.get(details_url)
 
     def test_scanpipe_views_codebase_relation_views(self):
         CodebaseRelation.objects.create(