From 8672cef7cd04ed5140672b8448ef2b7178a6e78d Mon Sep 17 00:00:00 2001 From: Andrew Bulat Date: Fri, 14 Feb 2025 10:32:18 +0000 Subject: [PATCH] Update error code for invalid credentials in tests See internal slack thread about the realtime update that changed the expected error code [1]. [1] https://ably-real-time.slack.com/archives/CURL4U2FP/p1736356509105489 --- test/ably/realtime/realtimeauth_test.py | 16 ++++++++-------- test/ably/realtime/realtimeconnection_test.py | 8 ++++---- test/ably/realtime/realtimeresume_test.py | 4 ++-- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/test/ably/realtime/realtimeauth_test.py b/test/ably/realtime/realtimeauth_test.py index 39213c72..15f93835 100644 --- a/test/ably/realtime/realtimeauth_test.py +++ b/test/ably/realtime/realtimeauth_test.py @@ -45,8 +45,8 @@ async def test_auth_wrong_api_key(self): ably = await TestApp.get_ably_realtime(key=api_key) state_change = await ably.connection.once_async(ConnectionState.FAILED) assert ably.connection.error_reason == state_change.reason - assert state_change.reason.code == 40005 - assert state_change.reason.status_code == 400 + assert state_change.reason.code == 40101 + assert state_change.reason.status_code == 401 await ably.close() async def test_auth_with_token_string(self): @@ -63,8 +63,8 @@ async def test_auth_with_invalid_token_string(self): invalid_token = "Sdnurv_some_invalid_token_nkds9r7" ably = await TestApp.get_ably_realtime(token=invalid_token) state_change = await ably.connection.once_async(ConnectionState.FAILED) - assert state_change.reason.code == 40005 - assert state_change.reason.status_code == 400 + assert state_change.reason.code == 40101 + assert state_change.reason.status_code == 401 await ably.close() async def test_auth_with_token_details(self): @@ -81,8 +81,8 @@ async def test_auth_with_invalid_token_details(self): invalid_token_details = TokenDetails(token="invalid-token") ably = await TestApp.get_ably_realtime(token_details=invalid_token_details) state_change = await ably.connection.once_async(ConnectionState.FAILED) - assert state_change.reason.code == 40005 - assert state_change.reason.status_code == 400 + assert state_change.reason.code == 40101 + assert state_change.reason.status_code == 401 await ably.close() async def test_auth_with_auth_callback_with_token_request(self): @@ -133,8 +133,8 @@ async def callback(params): ably = await TestApp.get_ably_realtime(auth_callback=callback) state_change = await ably.connection.once_async(ConnectionState.FAILED) - assert state_change.reason.code == 40005 - assert state_change.reason.status_code == 400 + assert state_change.reason.code == 40101 + assert state_change.reason.status_code == 401 await ably.close() async def test_auth_with_auth_url_json(self): diff --git a/test/ably/realtime/realtimeconnection_test.py b/test/ably/realtime/realtimeconnection_test.py index 31628b97..9d9b58f5 100644 --- a/test/ably/realtime/realtimeconnection_test.py +++ b/test/ably/realtime/realtimeconnection_test.py @@ -34,11 +34,11 @@ async def test_auth_invalid_key(self): state_change = await ably.connection.once_async() assert ably.connection.state == ConnectionState.FAILED assert state_change.reason - assert state_change.reason.code == 40005 - assert state_change.reason.status_code == 400 + assert state_change.reason.code == 40101 + assert state_change.reason.status_code == 401 assert ably.connection.error_reason - assert ably.connection.error_reason.code == 40005 - assert ably.connection.error_reason.status_code == 400 + assert ably.connection.error_reason.code == 40101 + assert ably.connection.error_reason.status_code == 401 await ably.close() async def test_connection_ping_connected(self): diff --git a/test/ably/realtime/realtimeresume_test.py b/test/ably/realtime/realtimeresume_test.py index 7d1a72e8..f37ea440 100644 --- a/test/ably/realtime/realtimeresume_test.py +++ b/test/ably/realtime/realtimeresume_test.py @@ -52,8 +52,8 @@ async def test_fatal_resume_error(self): ably.connection.connection_manager.notify_state(ConnectionState.DISCONNECTED) state_change = await ably.connection.once_async(ConnectionState.FAILED) - assert state_change.reason.code == 40005 - assert state_change.reason.status_code == 400 + assert state_change.reason.code == 40101 + assert state_change.reason.status_code == 401 await ably.close() # RTN15c7 - invalid resume response