Skip to content

Commit d3b4360

Browse files
committed
fix: ensure read_loop properly closed when disposing transport
1 parent 2cce6fc commit d3b4360

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

ably/transport/websockettransport.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,8 +231,16 @@ async def dispose(self):
231231
self.is_disposed = True
232232
if self.read_loop:
233233
self.read_loop.cancel()
234+
try:
235+
await self.read_loop
236+
except asyncio.CancelledError:
237+
pass
234238
if self.ws_connect_task:
235239
self.ws_connect_task.cancel()
240+
try:
241+
await self.ws_connect_task
242+
except asyncio.CancelledError:
243+
pass
236244
if self.idle_timer:
237245
self.idle_timer.cancel()
238246
if self.websocket:

0 commit comments

Comments
 (0)