Skip to content

Commit bf97ad9

Browse files
committed
ci: fix dev infra apply in pipeline
1 parent 79fc3cf commit bf97ad9

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

.github/workflows/infra-pipeline.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ jobs:
231231

232232
- name: Terraform Apply
233233
run: |
234-
terraform apply -backend-config=./dev/backend-config.hcl -var-file=./dev/terraform.tfvars --auto-approve
234+
terraform apply --auto-approve -var-file=./dev/terraform.tfvars
235235
env:
236236
ARM_CLIENT_ID: ${{ secrets.AZ_CLIENT_ID }}
237237
ARM_SUBSCRIPTION_ID: ${{ secrets.AZ_SUBSCRIPTION_ID }}

README.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,10 @@ Below is the list of the things we must do to make the implementation production
381381

382382
## IAC
383383
- Use `Terratest` for Integration test.
384-
- Implement a `Smoke/E2E` testing for IAC once the Infrastructure is provisioned. Execute on a scheduled event to detect any drift from the desired state defined as IAC.
384+
- Implement `Smoke/E2E` testing for IAC once the Infrastructure is provisioned. Execute on a scheduled event to detect any drift from the desired state defined as IAC.
385+
- Pass the plan artifact from plan to apply. Terraform best practice.
386+
- Analyze the pros and cons of TF workspace.
387+
- Analyze the pros and cons of Splitting the AZ Container Apps Environment provisioning through TF and AZ Container App deployment with configuration through Github Actions and YML configs.
385388

386389
## CI/CD
387390
- Refactor Github Actions Pipeline code to reduce Boilerplate code and practice DRY.

0 commit comments

Comments
 (0)