Initialize a2ui_core SDK with schema definitions and basic UI catalog components#1575
Initialize a2ui_core SDK with schema definitions and basic UI catalog components#1575nan-yu wants to merge 2 commits into
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
/gemini summary |
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
|
/gemini summary |
|
Warning Gemini encountered an error creating the summary. You can try again by commenting |
There was a problem hiding this comment.
Overall, this approach seems fantastic and we should adopt it in our other libraries.
Remind me again why we couldn't use something like https://pypi.org/project/json-schema-to-pydantic/ ? It'd be amazing if we didn't need to maintain so much special cased logic here. But also, we don't change the schema very often, so it's not a huge deal.
| return "\n".join(output) | ||
|
|
||
|
|
||
| def generate_basic_catalog_components( |
There was a problem hiding this comment.
Future idea: It could be nice to generalize this to generate_catalog_components at some point, so we can point it at any catalog file that adheres to our structure.
3 participants
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.