Skip to content

Some issues about the example and MzTransform() function #1

@YonghuiDong

Description

@YonghuiDong

Hi Zhiwei,

I am amazed by your nice work.

I enjoyed reading your publication. It is so comprehensive and informative. You work and the webserver is of great help to many of us!

When I checked your R package, I found most of the examples within the functions are not executable. Could you please check them?

For instance:

  • Installation of the package should be devtools::install_github("ZhuMetLab/AllCCS")
  • in MdGet() function, the parameter status_label is not described. id_allccs column does not exist for test data.
  • the m/z transform function is named as MzTransform, while in the example, it is called by mz_transform.

In addition, I have some doubts regarding MzTransform() function. It seems that the calculated m/z values are not correct.

For instance:

MzTransform(formula="C100H500OH", adduct = '[M+Na]+', polarity = 'pos')

output:

 M  adduct            mz
 1 1721.91879716 [M+Na]+ 1744.90809716

While the correct monoisotopic mass for this mass formula should be 1743.9044.

When the mass is small, the m/z difference is trivial, but the mass difference becomes obvious for compounds with bigger molecular weight.

Thanks again.

Dong

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions