-
Notifications
You must be signed in to change notification settings - Fork 5
Open
Description
Hi Zhiwei,
I am amazed by your nice work.
I enjoyed reading your publication. It is so comprehensive and informative. You work and the webserver is of great help to many of us!
When I checked your R package, I found most of the examples within the functions are not executable. Could you please check them?
For instance:
- Installation of the package should be
devtools::install_github("ZhuMetLab/AllCCS") - in
MdGet()function, the parameterstatus_labelis not described.id_allccscolumn does not exist fortestdata. - the m/z transform function is named as
MzTransform, while in the example, it is called bymz_transform.
In addition, I have some doubts regarding MzTransform() function. It seems that the calculated m/z values are not correct.
For instance:
MzTransform(formula="C100H500OH", adduct = '[M+Na]+', polarity = 'pos')
output:
M adduct mz
1 1721.91879716 [M+Na]+ 1744.90809716
While the correct monoisotopic mass for this mass formula should be 1743.9044.
When the mass is small, the m/z difference is trivial, but the mass difference becomes obvious for compounds with bigger molecular weight.
Thanks again.
Dong
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels