Skip to content
This repository was archived by the owner on Jan 19, 2019. It is now read-only.
This repository was archived by the owner on Jan 19, 2019. It is now read-only.

The checks for static errors are not consistent #28

@come-maiz

Description

@come-maiz

On the tests for the rules, when we expect an error we check that the return value is an array and that it contains one element. Some times we check the error message, and some other times we don't. But this is not really following any rules.

For each possible error message, we should check the string once. Some other tests variations are ok just checking that there is an error, but the current way to check for that is ugly and repeated many times. It could be a common helper.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions