✨ Add the new code of conduct packet

Author: YvanMazy

api/src/main/java/net/transferproxy/api/network/connection/PlayerConnection.java

@@ -76,6 +76,19 @@ default void transfer(final @NotNull String host) {
      */
     void sendStatusResponse(final @NotNull StatusResponse response);
 
+    /**
+     * Sends the code of conduct to the client.
+     * @param codeOfConduct The code of conduct to send.
+     * @return A CompletableFuture that will be completed when the code of conduct has been accepted by the client.
+     * @throws IllegalStateException if the code of conduct has already been sent and not yet accepted.
+     */
+    @NotNull CompletableFuture<Void> sendCodeOfConduct(final @NotNull String codeOfConduct);
+
+    /**
+     * Triggers the acceptance of the code of conduct.
+     */
+    void triggerAcceptCodeOfConduct();
+
     /**
      * Fetches a client-stored cookie using a {@link Key} reference.
      *

core/src/main/java/net/transferproxy/network/connection/PlayerConnectionImpl.java

@@ -57,7 +57,10 @@
 import org.slf4j.LoggerFactory;
 
 import java.net.SocketException;
-import java.util.*;
+import java.util.Collections;
+import java.util.Map;
+import java.util.Objects;
+import java.util.UUID;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ConcurrentHashMap;
 
@@ -82,6 +85,9 @@ public class PlayerConnectionImpl extends SimpleChannelInboundHandler<Serverboun
     private volatile boolean fromTransfer;
     private String brand;
 
+    private final Object codeOfConductLock = new Object();
+    private CompletableFuture<Void> codeOfConductFuture;
+
     public PlayerConnectionImpl(final @NotNull Channel channel) {
         this.channel = Objects.requireNonNull(channel, "channel must not be null");
     }
@@ -116,6 +122,33 @@ public void sendStatusResponse(final @NotNull StatusResponse response) {
         this.sendPacket(new StatusResponsePacket(response));
     }
 
+    @Override
+    public @NotNull CompletableFuture<Void> sendCodeOfConduct(final @NotNull String codeOfConduct) {
+        final CompletableFuture<Void> future = new CompletableFuture<>();
+        synchronized (this.codeOfConductLock) {
+            if (this.codeOfConductFuture != null) {
+                throw new IllegalStateException("Code of conduct already sent");
+            }
+            this.codeOfConductFuture = future;
+        }
+        this.sendPacket(new CodeOfConductPacket(codeOfConduct));
+        return future;
+    }
+
+    @Override
+    public void triggerAcceptCodeOfConduct() {
+        final CompletableFuture<Void> future;
+        synchronized (this.codeOfConductLock) {
+            future = this.codeOfConductFuture;
+            if (future != null) {
+                this.codeOfConductFuture = null;
+            }
+        }
+        if (future != null) {
+            future.complete(null);
+        }
+    }
+
     @Override
     public synchronized @NotNull CompletableFuture<byte[]> fetchCookie(final @NotNull String cookieKey) {
         Objects.requireNonNull(cookieKey, "Cookie key must not be null");

core/src/main/java/net/transferproxy/network/packet/config/clientbound/CodeOfConductPacket.java

@@ -0,0 +1,51 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2025 Yvan Mazy
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package net.transferproxy.network.packet.config.clientbound;
+
+import io.netty.buffer.ByteBuf;
+import net.transferproxy.api.network.packet.Packet;
+import net.transferproxy.api.network.protocol.Protocolized;
+import org.jetbrains.annotations.NotNull;
+
+import static net.transferproxy.util.BufUtil.readString;
+import static net.transferproxy.util.BufUtil.writeString;
+
+public record CodeOfConductPacket(String codeOfConduct) implements Packet {
+
+    public CodeOfConductPacket(final @NotNull ByteBuf buf) {
+        this(readString(buf));
+    }
+
+    @Override
+    public void write(final @NotNull Protocolized protocolized, final @NotNull ByteBuf buf) {
+        writeString(buf, this.codeOfConduct);
+    }
+
+    @Override
+    public int getId() {
+        return 0x13;
+    }
+
+}

core/src/main/java/net/transferproxy/network/packet/config/serverbound/AcceptCodeOfConductPacket.java

@@ -0,0 +1,54 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2025 Yvan Mazy
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package net.transferproxy.network.packet.config.serverbound;
+
+import io.netty.buffer.ByteBuf;
+import net.transferproxy.api.network.connection.PlayerConnection;
+import net.transferproxy.api.network.packet.serverbound.ServerboundPacket;
+import net.transferproxy.api.network.protocol.Protocolized;
+import org.jetbrains.annotations.NotNull;
+
+public record AcceptCodeOfConductPacket() implements ServerboundPacket {
+
+    public AcceptCodeOfConductPacket(final @SuppressWarnings("unused") @NotNull ByteBuf buf) {
+        this();
+    }
+
+    @Override
+    public void handle(final @NotNull PlayerConnection connection) {
+        connection.triggerAcceptCodeOfConduct();
+    }
+
+    @Override
+    public void write(final @NotNull Protocolized protocolized, final @NotNull ByteBuf buf) {
+        // nothing to write
+    }
+
+    @Override
+    public int getId() {
+        return 0x09;
+    }
+
+}

core/src/main/java/net/transferproxy/network/packet/provider/impl/LatestPacketProviderGroup.java

@@ -30,10 +30,7 @@
 import net.transferproxy.network.packet.config.FinishConfigurationPacket;
 import net.transferproxy.network.packet.config.KeepAlivePacket;
 import net.transferproxy.network.packet.config.PluginMessagePacket;
-import net.transferproxy.network.packet.config.serverbound.ClientInformationPacket;
-import net.transferproxy.network.packet.config.serverbound.ClientSelectKnownPacksPacket;
-import net.transferproxy.network.packet.config.serverbound.ConfigCookieResponsePacket;
-import net.transferproxy.network.packet.config.serverbound.ResourcePackResponsePacket;
+import net.transferproxy.network.packet.config.serverbound.*;
 import net.transferproxy.network.packet.handshake.HandshakePacket;
 import net.transferproxy.network.packet.login.serverbound.LoginAcknowledgedPacket;
 import net.transferproxy.network.packet.login.serverbound.LoginCookieResponsePacket;
@@ -62,6 +59,8 @@ public class LatestPacketProviderGroup implements PacketProviderGroup {
             .putNull() // Pong packet
             .putOnlyBuffer(ResourcePackResponsePacket::new)
             .putOnlyBuffer(ClientSelectKnownPacksPacket::from)
+            .putNull() // Custom Click Action packet
+            .putOnlyBuffer(AcceptCodeOfConductPacket::new)
             .build();
     // @formatter:on
 

core/src/test/java/net/transferproxy/network/packet/config/clientbound/CodeOfConductPacketTest.java

@@ -0,0 +1,43 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2025 Yvan Mazy
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package net.transferproxy.network.packet.config.clientbound;
+
+import net.transferproxy.network.packet.PacketTestBase;
+import org.junit.jupiter.api.Test;
+
+class CodeOfConductPacketTest extends PacketTestBase {
+
+    @Test
+    void testWriteReadConsistency() {
+        this.testOnlyBuffer(new CodeOfConductPacket("My code of conduct"), CodeOfConductPacket::new);
+        this.testOnlyBuffer(new CodeOfConductPacket("a".repeat(Short.MAX_VALUE)), CodeOfConductPacket::new);
+    }
+
+    @Test
+    void testWriteTooLongCodeOfConduct() {
+        this.testFailOnlyBuffer(new CodeOfConductPacket("a".repeat(Short.MAX_VALUE + 1)), CodeOfConductPacket::new);
+    }
+
+}

core/src/test/java/net/transferproxy/network/packet/config/serverbound/AcceptCodeOfConductPacketTest.java

@@ -0,0 +1,37 @@
+/*
+ * MIT License
+ *
+ * Copyright (c) 2025 Yvan Mazy
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+package net.transferproxy.network.packet.config.serverbound;
+
+import net.transferproxy.network.packet.PacketTestBase;
+import org.junit.jupiter.api.Test;
+
+class AcceptCodeOfConductPacketTest extends PacketTestBase {
+
+    @Test
+    void testWriteReadConsistency() {
+        this.testOnlyBuffer(new AcceptCodeOfConductPacket(), AcceptCodeOfConductPacket::new);
+    }
+
+}