E_DEPRECATED: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated

[kkmuffme]

• I've read and understood the contribution guidelines.
• I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

To Reproduce

Step-by-step reproduction instructions

/wp-admin/admin.php?page=wpseo_page_settings
when saving get to page /wp-admin/admin.php?page=wpseo_page_settings_saved&settings-updated=true

Expected results

no error

Actual results

E_DEPRECATED: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated
in \wp-admin\admin-header.php on line 36

It seems you didn't set a title for the page when registering it

Screenshots, screen recording, code snippet

If possible, please provide a screenshot, a screen recording or a code snippet which demonstrates the bug.

Technical info

Used versions

• PHP version: 8.3
• WordPress version: 6.6
• Yoast SEO version: 24.3

[josevarghese]

PR available here: #22056
Update The committer closed the PR

[dilipbheda]

Steps to Reproduce

1. Change the PHP version to PHP 8.2.*
2. Enable the WordPress debug log (Reference: Debugging in WordPress)
3. Navigate to the WordPress admin panel: {siteurl}/wp-admin/admin.php?page=wpseo_page_settings_saved
4. The error should be visible on the page.

[sabernhardt]

Please try using 'options.php' instead of an empty string as the first parameter for any add_submenu_page() function, and verify that everything works as expected.

I was able to remove the deprecation notice on {site_url}/wp-admin/admin.php?page=wpseo_installation_successful_free by adding 'options.php':

wordpress-seo/src/integrations/admin/installation-success-integration.php

Lines 111 to 114 in 3d1950c

	public function add_submenu_page( $submenu_pages ) {
	\add_submenu_page(
	'',
	\__( 'Installation Successful', 'wordpress-seo' ),

.

The settings saved page likely has a deprecated message as a result of the empty string in settings-integration.php

wordpress-seo/src/integrations/settings-integration.php

Lines 400 to 403 in 3d1950c

	public function add_settings_saved_page( $pages ) {
	$runner = $this->runner;
	\add_submenu_page(
	'',

[josevarghese]

@sabernhardt Since you've proposed a solution, could you please submit a pull request (PR) with the fix? If you're unsure how to create a PR, we have detailed documentation to guide you here: https://github.com/Yoast/wordpress-seo/blob/trunk/.github/CONTRIBUTING.md#fixing-an-issue

Looking forward.

[sabernhardt]

PR submitted, editing four add_submenu_page() functions and their corresponding tests.

[josevarghese]

Thank you, @sabernhardt for the PR and for the contribution. Our development team will review it and share feedback with you. Our developers work on the highest priority first. Unfortunately, this means we cannot give you an estimate when they'll start reviewing it.