DMA-Proxy broken

[simonwaid]

dma-proxy.c does not compile on the latest petalinux version. Some issues:

• Line 444: should probably read return PTR_ERR(local_class_p); instead of return ERR_PTR(local_class_p)
• Line 639: should be static void dma_proxy_remove(struct platform_device *pdev) instead of static int dma_proxy_remove(struct platform_device *pdev)
• Line 665: No return value for void

[simonwaid]

Update: It seems like Petalinux 2025.1 wants dma_proxy_remove to be of type void, while Petalinux 2023.2 wants it to return an int.

[simonwaid]

It seems like more was broken. Attaching a version that seems to work for Petalinux 2023.2.
dma-proxy.c

[cwcagilent]

I changed the int to void for the .remove function. Now it compiles, but causes a kernel OOPS when loading. Please help!

[ 28.376304] dma_proxy: loading out-of-tree module taints kernel.
[ 28.376967] dma_proxy module initialized
[ 28.376976] Device Tree Channel Count: 2
[ 28.376983] Creating channel dma_proxy_tx
[ 28.379841] Allocating memory, virtual address: ffff00006be00000 physical address: 000000006be00000
[ 28.379857] 0: 000000006be00000
[ 28.379862] 1: 000000006be20400
[ 28.379867] 2: 000000006be40800
[ 28.379871] 3: 000000006be60c00
[ 28.379876] 4: 000000006be81000
[ 28.379880] 5: 000000006bea1400
[ 28.379884] 6: 000000006bec1800
[ 28.379889] 7: 000000006bee1c00
[ 28.379893] 8: 000000006bf02000
[ 28.379898] 9: 000000006bf22400
[ 28.379902] 10: 000000006bf42800
[ 28.379907] 11: 000000006bf62c00
[ 28.379912] 12: 000000006bf83000
[ 28.379916] 13: 000000006bfa3400
[ 28.379921] 14: 000000006bfc3800
[ 28.379925] 15: 000000006bfe3c00
[ 28.379930] 16: 000000006c004000
[ 28.379934] 17: 000000006c024400
[ 28.379939] 18: 000000006c044800
[ 28.379943] 19: 000000006c064c00
[ 28.379947] 20: 000000006c085000
[ 28.379952] 21: 000000006c0a5400
[ 28.379956] 22: 000000006c0c5800
[ 28.379960] 23: 000000006c0e5c00
[ 28.379965] 24: 000000006c106000
[ 28.379969] 25: 000000006c126400
[ 28.379974] 26: 000000006c146800
[ 28.379978] 27: 000000006c166c00
[ 28.379983] 28: 000000006c187000
[ 28.379987] 29: 000000006c1a7400
[ 28.379991] 30: 000000006c1c7800
[ 28.379996] 31: 000000006c1e7c00
[ 28.380001] Creating channel dma_proxy_rx
[ 28.380188] Unable to handle kernel paging request at virtual address 000ff00f0f0f0f5f
[ 28.388123] Mem abort info:
[ 28.390917] ESR = 0x0000000096000004
[ 28.394710] EC = 0x25: DABT (current EL), IL = 32 bits
[ 28.400024] SET = 0, FnV = 0
[ 28.403077] EA = 0, S1PTW = 0
[ 28.406219] FSC = 0x04: level 0 translation fault
[ 28.411098] Data abort info:
[ 28.413979] ISV = 0, ISS = 0x00000004, ISS2 = 0x00000000
[ 28.419465] CM = 0, WnR = 0, TnD = 0, TagAccess = 0
[ 28.424518] GCS = 0, Overlay = 0, DirtyBit = 0, Xs = 0
[ 28.429829] [000ff00f0f0f0f5f] address between user and kernel address ranges
[ 28.436966] Internal error: Oops: 0000000096000004 [#1] SMP
[ 28.442528] Modules linked in: dma_proxy(O+) cfg80211 iptable_filter xt_conntrack uio_pdrv_genirq
[ 28.451411] CPU: 3 UID: 0 PID: 948 Comm: insmod Tainted: G O 6.12.10-xilinx-g0a0f70e531c7 #1
[ 28.461226] Tainted: [O]=OOT_MODULE
[ 28.464705] Hardware name: xlnx,zynqmp (DT)
[ 28.468872] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 28.475824] pc : device_get_ownership+0x8/0x30
[ 28.480268] lr : kobject_get_ownership+0x24/0x34
[ 28.484877] sp : ffff80008359b520
[ 28.488176] x29: ffff80008359b520 x28: 0000000000000000 x27: ffff000801672b50
[ 28.495311] x26: 0000000000000000 x25: ffffffffff6057f5 x24: 0000000000000000
[ 28.502437] x23: 000000000ea00000 x22: ffff800081208650 x21: ffff00080003fa18
[ 28.509572] x20: 0000000000000000 x19: ffff0008034ce000 x18: 0000000000000000
[ 28.516699] x17: 6461206c61636973 x16: 7968702030303030 x15: 0000000000000000
[ 28.523825] x14: 0000000000000000 x13: 0078725f79786f72 x12: 705f616d643a616d
[ 28.530951] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000
[ 28.538078] x8 : ffff00080505a000 x7 : ffff80008359b670 x6 : ffff80008359b670
[ 28.545204] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0f0ff00f0f0f0f0f
[ 28.552330] x2 : ffff80008359b534 x1 : ffff80008359b530 x0 : ffff0008034ce000
[ 28.559457] Call trace:
[ 28.561887] device_get_ownership+0x8/0x30
[ 28.565975] sysfs_create_dir_ns+0x58/0x114
[ 28.570151] kobject_add_internal+0xa8/0x340
[ 28.574413] kobject_add+0xa0/0x114
[ 28.577893] device_add+0xac/0x734
[ 28.581287] device_create_groups_vargs+0xe0/0x134
[ 28.586070] device_create+0x60/0x8c
[ 28.589637] dma_proxy_probe+0x240/0x634 [dma_proxy]
[ 28.594602] platform_probe+0x68/0xc4
[ 28.598257] really_probe+0xbc/0x29c
[ 28.601824] __driver_probe_device+0x78/0x12c
[ 28.606173] driver_probe_device+0xd8/0x15c
[ 28.610348] __driver_attach+0x90/0x19c
[ 28.614176] bus_for_each_dev+0x7c/0xe0
[ 28.618004] driver_attach+0x24/0x30
[ 28.621571] bus_add_driver+0xe4/0x208
[ 28.625313] driver_register+0x5c/0x124
[ 28.629141] __platform_driver_register+0x24/0x30
[ 28.633837] dma_proxy_init+0x20/0x1000 [dma_proxy]
[ 28.638706] do_one_initcall+0x80/0x1c8
[ 28.642534] do_init_module+0x60/0x218
[ 28.646275] load_module+0x1ba0/0x1d50
[ 28.650016] init_module_from_file+0x88/0xcc
[ 28.654278] __arm64_sys_finit_module+0x200/0x3f0
[ 28.658974] invoke_syscall+0x54/0x11c
[ 28.662715] el0_svc_common.constprop.0+0xc0/0xe0
[ 28.667411] do_el0_svc+0x1c/0x28
[ 28.670718] el0_svc+0x30/0xcc
[ 28.673765] el0t_64_sync_handler+0x120/0x12c
[ 28.678113] el0t_64_sync+0x190/0x194
[ 28.681772] Code: aa0103e0 d65f03c0 f9415c03 b4000143 (f9402863)
[ 28.687854] ---[ end trace 0000000000000000 ]---

Edit, issue 14 contains a fix for this.
Simply move pchannel_p->class_p = local_class_p; to outside (after) the if statement.