Skip to content

puppeteer imported but not in dependencies #152

@regseb

Description

@regseb

Description

puppeteer is imported into the source code, but it's not into the published dependencies.

I use ghost-cursor, but I don't have puppeteer (I use playwright).

I think ghost-cursor should export two files:

  • One with basic features that doesn't use puppeteer: path()
  • Another with all features, including those requiring puppeteer: path(), createCursor()...

To reproduce

  • package.json

    {
      "name": "testcase",
      "version": "1.0.0",
      "type": "module",
      "dependencies": {
        "ghost-cursor": "1.3.0",
        "typescript": "5.7.3"
      }
    }
  • index.ts

    import { path } from "ghost-cursor";
  1. npm install
  2. npx tsc index.ts
    node_modules/ghost-cursor/lib/mouse-helper.d.ts:1:27 - error TS2307: Cannot find module 'puppeteer' or its corresponding type declarations.
    
    1 import type { Page } from 'puppeteer';
                                ~~~~~~~~~~~
    
    node_modules/ghost-cursor/lib/spoof.d.ts:1:50 - error TS2307: Cannot find module 'puppeteer' or its corresponding type declarations.
    
    1 import { ElementHandle, Page, BoundingBox } from 'puppeteer';
                                                       ~~~~~~~~~~~
    
    
    Found 2 errors in 2 files.
    
    Errors  Files
         1  node_modules/ghost-cursor/lib/mouse-helper.d.ts:1
         1  node_modules/ghost-cursor/lib/spoof.d.ts:1
    

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions