Select_one from repeat does not support fields nested in groups within a repeat

[lognaturel]

Software and hardware versions

pyxform v1.3.3

Problem description

Values in repeats may be nested in one or more groups. These need to be accounted for in the expressions generated by select_one from repeat.

Steps to reproduce the problem

See form at https://forum.getodk.org/t/generate-multiple-choice-alternatives-based-on-the-answers-in-a-repeat/10269/21?u=ln

[lindsay-stevens]

For future reference, I checked this case with the changes in #777 but it's still broken. The test (code below) fails ODK Validate which says the XForm is invalid:

<repeat> member's binding [${g1t}] is within the scope of a <repeat> that is not its closest containing <repeat>!

This seems like a javarosa validation bug, because the comment in FormInstanceParser near the code that emits this error seems to be for a different issue of repeats not being nested properly:

//catch <repeat nodeset="/a/b"><input ref="/a/b/c/d" /></repeat>...<repeat nodeset="/a/b/c">...</repeat>:
//  question's/group's/repeat's most immediate repeat parent in the instance is not its most immediate repeat parent in the form def

Test case adapted from the linked forum post:

    def test_for_506(self):
        md = """
        | survey |
        |        | type            | name | label  | calculation  |
        |        | begin repeat    | a    | a      |              |
        |        | begin group     | g1t  | g1t    |              |
        |        | text            | t    | target |              |
        |        | select_one ${t} | s    | source |              |
        |        | end group       | g1t  |        |              |
        |        | end repeat      | a    |        |              |
        """
        self.assertPyxformXform(
            md=md,
            run_odk_validate=True,
        )

XForm produced:

<?xml version="1.0"?>
<h:html xmlns="http://www.w3.org/2002/xforms" xmlns:h="http://www.w3.org/1999/xhtml" xmlns:ev="http://www.w3.org/2001/xml-events" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:jr="http://openrosa.org/javarosa" xmlns:orx="http://openrosa.org/xforms" xmlns:odk="http://www.opendatakit.org/xforms">
  <h:head>
    <h:title>data</h:title>
    <model odk:xforms-version="1.0.0">
      <instance>
        <test_name id="data">
          <a jr:template="">
            <g1t>
              <t/>
              <s/>
            </g1t>
          </a>
          <a>
            <g1t>
              <t/>
              <s/>
            </g1t>
          </a>
          <meta>
            <instanceID/>
          </meta>
        </test_name>
      </instance>
      <bind nodeset="/test_name/a/g1t/t" type="string"/>
      <bind nodeset="/test_name/a/g1t/s" type="string"/>
      <bind nodeset="/test_name/meta/instanceID" type="string" readonly="true()" jr:preload="uid"/>
    </model>
  </h:head>
  <h:body>
    <group ref="/test_name/a">
      <label>a</label>
      <repeat nodeset="/test_name/a">
        <group ref="/test_name/a/g1t">
          <label>g1t</label>
          <input ref="/test_name/a/g1t/t">
            <label>target</label>
          </input>
          <select1 ref="/test_name/a/g1t/s">
            <label>source</label>
            <itemset nodeset="../../../a/g1t[./t != '']">
              <value ref="t"/>
              <label ref="t"/>
            </itemset>
          </select1>
        </group>
      </repeat>
    </group>
  </h:body>
</h:html>
```