Skip to content

Commit 57c8efc

Browse files
committed
feedback
1 parent b158865 commit 57c8efc

3 files changed

Lines changed: 6 additions & 3 deletions

File tree

packages/fields/src/components/media-edit/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,14 +207,14 @@ export default function MediaEdit< Item >( {
207207
[ value ]
208208
);
209209
const onChangeControl = useCallback(
210-
( newValue: number | number[] ) =>
210+
( newValue: number | number[] | undefined ) =>
211211
onChange( field.setValue( { item: data, value: newValue } ) ),
212212
[ data, field, onChange ]
213213
);
214214
const removeItem = ( itemId: number ) => {
215215
const currentIds = Array.isArray( value ) ? value : [ value ];
216216
const newIds = currentIds.filter( ( id ) => id !== itemId );
217-
onChangeControl( newIds.length ? newIds : 0 );
217+
onChangeControl( newIds.length ? newIds : undefined );
218218
};
219219
return (
220220
<fieldset className="fields__media-edit" data-field-id={ field.id }>

packages/fields/src/components/media-edit/style.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ fieldset.fields__media-edit {
1818
display: flex;
1919
align-items: center;
2020
gap: $grid-unit-15;
21-
border: $border-width dotted $gray-300;
21+
border: $border-width dashed $gray-300;
2222
border-radius: $radius-small;
2323
padding: calc(8px - #{$border-width});
2424
cursor: pointer;

packages/fields/src/fields/featured-image/index.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ const featuredImageField: Field< BasePostWithEmbeddedFeaturedMedia > = {
1717
label: __( 'Featured Image' ),
1818
Edit: MediaEdit,
1919
render: FeaturedImageView,
20+
setValue: ( { value } ) => ( {
21+
featured_media: value ? Number( value ) : 0,
22+
} ),
2023
enableSorting: false,
2124
filterBy: false,
2225
};

0 commit comments

Comments
 (0)