Improvement to Issue Sync

Author: stefan-ernst

internal/repository/item_repository.go

@@ -4,6 +4,7 @@ import (
 	"database/sql"
 	"encoding/json"
 	"fmt"
+	"strings"
 	"time"
 
 	"windshift/internal/database"
@@ -336,6 +337,46 @@ func (r *ItemRepository) Update(tx database.Tx, item *models.Item) error {
 	return nil
 }
 
+// allowedItemColumns is the whitelist of columns that UpdateFields may touch.
+var allowedItemColumns = map[string]bool{
+	"title": true, "description": true, "status_id": true, "priority_id": true,
+	"due_date": true, "start_date": true, "end_date": true,
+	"milestone_id": true, "iteration_id": true, "project_id": true, "inherit_project": true,
+	"assignee_id": true, "creator_id": true, "custom_field_values": true,
+	"parent_id": true, "related_work_item_id": true, "item_type_id": true,
+	"frac_index": true, "is_task": true, "time_project_id": true,
+}
+
+// UpdateFields updates only the specified columns of an item.
+// Keys must be valid item column names; unknown keys return an error.
+func (r *ItemRepository) UpdateFields(tx database.Tx, itemID int, fields map[string]interface{}) error {
+	if len(fields) == 0 {
+		return nil
+	}
+
+	setClauses := make([]string, 0, len(fields)+1)
+	args := make([]interface{}, 0, len(fields)+2)
+
+	for col, val := range fields {
+		if !allowedItemColumns[col] {
+			return fmt.Errorf("unknown item column: %s", col)
+		}
+		setClauses = append(setClauses, col+" = ?")
+		args = append(args, val)
+	}
+
+	setClauses = append(setClauses, "updated_at = ?")
+	args = append(args, time.Now())
+	args = append(args, itemID)
+
+	query := "UPDATE items SET " + strings.Join(setClauses, ", ") + " WHERE id = ?"
+	_, err := tx.Exec(query, args...)
+	if err != nil {
+		return fmt.Errorf("failed to update item fields: %w", err)
+	}
+	return nil
+}
+
 // Delete removes an item by ID
 func (r *ItemRepository) Delete(tx database.Tx, id int) error {
 	_, err := tx.Exec("DELETE FROM items WHERE id = ?", id)

internal/scm/github.go

@@ -8,6 +8,7 @@ import (
 	"encoding/pem"
 	"fmt"
 	"io"
+	"log/slog"
 	"net/http"
 	"net/url"
 	"strconv"
@@ -1047,46 +1048,57 @@ func (g *GitHubProvider) ListIssueComments(ctx context.Context, owner, repo stri
 		return nil, err
 	}
 
-	reqURL := fmt.Sprintf("%s/repos/%s/%s/issues/%d/comments?per_page=100", g.baseURL, owner, repo, number)
+	var allComments []IssueComment
+	page := 1
+	for {
+		reqURL := fmt.Sprintf("%s/repos/%s/%s/issues/%d/comments?per_page=100&page=%d", g.baseURL, owner, repo, number, page)
 
-	req, err := http.NewRequestWithContext(ctx, "GET", reqURL, http.NoBody)
-	if err != nil {
-		return nil, err
-	}
-	g.setAuthHeader(req)
+		req, err := http.NewRequestWithContext(ctx, "GET", reqURL, http.NoBody)
+		if err != nil {
+			return nil, err
+		}
+		g.setAuthHeader(req)
 
-	resp, err := g.httpClient.Do(req)
-	if err != nil {
-		return nil, err
-	}
-	defer func() { _ = resp.Body.Close() }()
+		resp, err := g.httpClient.Do(req)
+		if err != nil {
+			return nil, err
+		}
 
-	if resp.StatusCode != http.StatusOK {
-		return nil, g.handleErrorResponse(resp)
-	}
+		if resp.StatusCode != http.StatusOK {
+			err := g.handleErrorResponse(resp)
+			_ = resp.Body.Close()
+			return nil, err
+		}
 
-	var ghComments []struct {
-		ID        int64      `json:"id"`
-		Body      string     `json:"body"`
-		User      githubUser `json:"user"`
-		CreatedAt time.Time  `json:"created_at"`
-		UpdatedAt time.Time  `json:"updated_at"`
-	}
-	if err := json.NewDecoder(resp.Body).Decode(&ghComments); err != nil {
-		return nil, err
-	}
+		var ghComments []struct {
+			ID        int64      `json:"id"`
+			Body      string     `json:"body"`
+			User      githubUser `json:"user"`
+			CreatedAt time.Time  `json:"created_at"`
+			UpdatedAt time.Time  `json:"updated_at"`
+		}
+		if err := json.NewDecoder(resp.Body).Decode(&ghComments); err != nil {
+			_ = resp.Body.Close()
+			return nil, err
+		}
+		_ = resp.Body.Close()
+
+		for _, c := range ghComments {
+			allComments = append(allComments, IssueComment{
+				ID:        c.ID,
+				Body:      c.Body,
+				User:      c.User.toUser(),
+				CreatedAt: c.CreatedAt,
+				UpdatedAt: c.UpdatedAt,
+			})
+		}
 
-	comments := make([]IssueComment, len(ghComments))
-	for i, c := range ghComments {
-		comments[i] = IssueComment{
-			ID:        c.ID,
-			Body:      c.Body,
-			User:      c.User.toUser(),
-			CreatedAt: c.CreatedAt,
-			UpdatedAt: c.UpdatedAt,
+		if len(ghComments) < 100 {
+			break
 		}
+		page++
 	}
-	return comments, nil
+	return allComments, nil
 }
 
 // UpdateIssueComment updates an existing comment on an issue
@@ -1328,7 +1340,9 @@ func (g *GitHubProvider) handleErrorResponse(resp *http.Response) error {
 	case http.StatusUnauthorized:
 		return ErrInvalidCredentials
 	case http.StatusForbidden:
-		if strings.Contains(bodyStr, "rate limit") {
+		if strings.Contains(bodyStr, "rate limit") || resp.Header.Get("X-RateLimit-Remaining") == "0" {
+			resetAt := resp.Header.Get("X-RateLimit-Reset")
+			slog.Warn("GitHub rate limit hit", "reset_at", resetAt)
 			return ErrRateLimited
 		}
 		if bodyStr != "" {