Skip to content

LD App didn't verify command length when received commands #350

@ynielson

Description

@ynielson

When the LD app received the commands like "LD_MODE_AUTO_CC" and "LD_MODE_MANUAL_CC",
it didn't verify the command length by calling the existing function, "VerifyCmdLength()".
Even though these commands are the "LD_NoArgCmd_t" type, these commands are significant.

And just in case if this matters,
the function, VerifyCmdLength(), sent the event message with msgID formatted "0x%08X" instead of "0x%04X".
The MsgID is the type CFE_SB_MsgId_t(uint16) and usually printed as the format "0x%04X".
But only this function, VerifyCmdLength(), printed it formatted "0x%08X" in most of the apps,
except several apps like sch, to, ci_nasa, cs.

  • test case: Test_LD_VerifyCmdLength_Fail_CmdLength
    ld_VerifyCmdLength_2023-03-30 13-45-08

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions