defaultstoredays in formintegration no longer supported

[Anferney1205]

We have a few module in which we use the defaultstoredays in formintegration, but it looks like it is no longer supported in 5.9.
Is there an other way that defaultstoredays should be set now?

[krisbreuker]

The default number of days to store form results can be set through the registry key publisher.forms.storeresults. There is currently no way to easily overwrite this value, e.g. through site profiles.

[Anferney1205]

So there really is not other way anymore? It used to be possible to define it in the siteprofile like this <formintegration defaultstoredays="5475" />, but got removed in this commit: 00505baade0642bfcbb893578288c859be0efed9 [00505baad]
While the commit mentions it eliminates some 'unused form configuration', we have quite a few modules which depend on the defaultstoredays configuration.

It would be nice to have an alternative to this rather than having to change it for the entire server.

[unilynx]

Does https://gitlab.webhare.com/webhare-opensource/platform/-/merge_requests/2999 work?

(there was never any test coverage for this so we need to rely on manual reports)

[Anferney1205]

The settings screen is now working, but it looks like the store days still uses the default value from the registry instead of the one from

[unilynx]

Can you log or abort in GetFormResultsExpirationDaysByInstance and check what the actual storeresults value is ?

[Anferney1205]

This is the abort:

Custom error message: '400'.
At mod::publisher/lib/internal/forms/results.whlib(828,1)

Trace:
mod::publisher/lib/internal/forms/results.whlib(828,1) GETFORMRESULTSEXPIRATIONDAYSBYINSTANCE
mod::publisher/tolliumapps/formedit/formedit.whlib(603,26) EDITOR#REFRESHSTORERESULTSUI
mod::publisher/tolliumapps/formedit/formedit.whlib(161,11) EDITOR#INIT
mod::tollium/lib/screenbase.whlib(1002,15) TOLLIUMSCREENBASE#TOLLIUMINITIALIZESCREEN
mod::tollium/lib/internal/controllerbase.whlib(2008,17) TOLLIUMCONTROLLERBASE#PVT_LOADSCREEN
mod::tollium/lib/screenbase.whlib(612,47) TOLLIUMSCREENBASE#LOADSCREEN
mod::publisher/tolliumapps/editdocument/editdocument.whlib(257,33) EDITDOCUMENTAPP#SETUPFORFILEEDIT
mod::publisher/tolliumapps/editdocument/editdocument.whlib(112,11) EDITDOCUMENTAPP#INIT
mod::tollium/lib/screenbase.whlib(1002,15) TOLLIUMSCREENBASE#TOLLIUMINITIALIZESCREEN
mod::tollium/lib/internal/controllerbase.whlib(2008,17) TOLLIUMCONTROLLERBASE#PVT_LOADSCREEN
mod::tollium/lib/internal/controllerbase.whlib(2094,18) TOLLIUMCONTROLLERBASE#LOADSCREEN
mod::tollium/lib/internal/controllerbase.whlib(2253,32) TOLLIUMCONTROLLERBASE#__DOINTEGRATEDAPPLAUNCH
mod::publisher/lib/dialogs.whlib(522,47) RUNFSOBJECTEDITAPPLICATION
mod::publisher/tolliumapps/filemanager/main.whlib(2197,5) RUNDIRECTEDIT
mod::tollium/lib/internal/controllerbase.whlib(2248,11) TOLLIUMCONTROLLERBASE#__DOINTEGRATEDAPPLAUNCH
mod::tollium/lib/internal/controllerbase.whlib(2237,15) TOLLIUMCONTROLLERBASE#LAUNCHAPPLICATIONINSIDEAPP
mod::tollium/lib/internal/controllerbase.whlib(2190,11) TOLLIUMCONTROLLERBASE#LAUNCHTHEAPPLICATION
mod::tollium/lib/internal/controllerbase.whlib(2164,15) TOLLIUMCONTROLLERBASE#LAUNCHAPPLICATION
mod::tollium/lib/todd/internal/controller.whlib(475,28) TOLLIUMWEBCONTROLLER#LAUNCHAPPLICATION
mod::tollium/scripts/internal/applicationhost.whscr(142,16) :INITFUNCTION

[unilynx]

I see a part missing in the parser. committed now. If that doesn't fix it:

And what was the expected number? Does the Inspect dialog on the form show the siteprofile rule active?

What is the result of GetFormPluginConfiguration(applytester) ?

[Anferney1205]

Yes, it is working now.

Thank you for restoring this feature.