Skip to content

C API inconsistency on CallRef's isReturn #8110

@kripken

Description

@kripken

CallRef gets an isReturn param

binaryen/src/binaryen-c.h

Lines 1014 to 1020 in 93f40ae

BINARYEN_API BinaryenExpressionRef
BinaryenCallRef(BinaryenModuleRef module,
BinaryenExpressionRef target,
BinaryenExpressionRef* operands,
BinaryenIndex numOperands,
BinaryenType type,
bool isReturn);

while Call/CallIndirect have two variants instead, BinaryenCall, BinaryenReturnCall. We should probably standardize on one.

Noticed in #8103

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions