fix: autoinvoke is now disabled by default

Torwent · Torwent · commit a65407532566 · 2026-01-30T12:17:39.000+01:00
This means you need to add `()` to your functions unless you add `{$AUTOINVOKE ON}` to your script
diff --git a/examples/gear_form.simba b/examples/gear_form.simba
@@ -13,7 +13,7 @@ begin
 
   WriteLn('Main Gear: ', gear1.Gear);
   WriteLn('SpecAttack Gear: ', gear2.Gear);
-  inherited;
+  inherited();
 end;
 
 var
diff --git a/examples/inventory_form.simba b/examples/inventory_form.simba
@@ -9,7 +9,7 @@ begin
   layout.Layout := InventoryForm.Layouts[layoutSelector.ItemIndex];
 
   WriteLn('Inventory Layout: ', layout.Layout);
-  inherited;
+  inherited();
 end;
 
 var
diff --git a/osrs/antiban/antibantasks.simba b/osrs/antiban/antibantasks.simba
@@ -214,7 +214,7 @@ begin
 
   WriteLn GetDebugLn('Antiban', 'Toggling make quantity buttons');
 
-  quantityBtns := Make.FindQuantityButtons;
+  quantityBtns := Make.FindQuantityButtons();
   if quantityBtns = [] then Exit;
   currentBtn := Make.GetCurrentQuantity();
   randomBtn := quantityBtns[Random(Length(quantityBtns))];
diff --git a/osrs/finders/itemfinder.simba b/osrs/finders/itemfinder.simba
@@ -71,7 +71,7 @@ begin
   if not Self._AlignHelper(image, tBorder, bBorder, align) then
     Exit;
 
-  bounds := tBorder.Bounds;
+  bounds := tBorder.Bounds();
   image.Crop(bounds);
 
   bounds := bounds.Offset([-align.X, -align.Y]);
diff --git a/osrs/finders/overheadfinder.simba b/osrs/finders/overheadfinder.simba
@@ -206,7 +206,7 @@ begin
 
       matrix := MatchTemplate(Target.GetImage(bounds), overheadImage, ETMFormula.TM_CCOEFF_NORMED);
 
-      with matrix.ArgMax do
+      with matrix.ArgMax() do
       begin
         if matrix[Y,X] < Self.Similarity then
           Break;
diff --git a/osrs/interfaces/chat/chat.simba b/osrs/interfaces/chat/chat.simba
@@ -456,7 +456,7 @@ begin
   // Now find shadows, offset by -1,-1 to find colors of text
   tpa := img.FindColor(0, 0, [1, 1, img.Width, img.Height]);
   tpa := tpa.Offset([-1,-1]).ExcludePoints(tpa);
-  img.ReplaceColorBinary(False, img.GetColors(tpa).Unique, 0);
+  img.ReplaceColorBinary(False, img.GetColors(tpa).Unique(), 0);
 
   Result := OCR.Engine.Recognize(img, RSFonts.PLAIN_12, [0,0]);
 end;
diff --git a/osrs/interfaces/chooseoption.simba b/osrs/interfaces/chooseoption.simba
@@ -164,8 +164,8 @@ begin
   atpa := tpa.Cluster(2).ExcludeSize(100, __LT__).SortFrom(Mouse.Position);
 
   for tpa in atpa do
-    if tpa.Bounds.Corners.Intersection(tpa).Length = 4 then
-      Exit(tpa.Bounds.Expand(-2));
+    if tpa.Bounds().Corners().Intersection(tpa).Length = 4 then
+      Exit(tpa.Bounds().Expand(-2));
 end;
 
 (*
diff --git a/osrs/interfaces/gametabs/inventory.simba b/osrs/interfaces/gametabs/inventory.simba
@@ -432,12 +432,12 @@ begin
 
   if not Self.ShiftEnabled then Exit(Self.Drop(slots));
 
-  boxes := Self.Slots.Boxes;
+  boxes := Self.Slots.Boxes();
   for 1 to attempts do
   begin
     for i := 0 to High(slots) do
     begin
-      if Self.GetSelected > -1 then
+      if Self.GetSelected() > -1 then
       begin
         Self.Select(-1);
         Continue(2);
diff --git a/osrs/interfaces/gametabs/magic.simba b/osrs/interfaces/gametabs/magic.simba
@@ -405,7 +405,7 @@ begin
   if Length(tpa) <= 10 then Exit;
 
   for tpa in tpa.Cluster(8) do
-    if tpa.Density < 0.28 then
+    if tpa.Density() < 0.28 then
       Exit(True);
   tpa := [];
 end;
diff --git a/osrs/interfaces/gametabs/prayer.simba b/osrs/interfaces/gametabs/prayer.simba
@@ -134,7 +134,7 @@ WriteLn Prayer.InfoIsOpen();
 *)
 function TRSPrayer.InfoIsOpen(): Boolean;
 begin
-  Result := Self.GetInfoBox <> [];
+  Result := Self.GetInfoBox() <> [];
 end;
 
 (*
@@ -192,7 +192,7 @@ begin
   if attempts = 0 then Exit;
 
   if Self.InfoIsOpen() then
-    Result := Self.CloseInfo and Self.Find(prayer, bounds, attempts-1);
+    Result := Self.CloseInfo() and Self.Find(prayer, bounds, attempts-1);
 end;
 
 (*
@@ -332,7 +332,7 @@ var
   activatedPrayers: TRSPrayerSet;
 begin
   Result := True;
-  if not Self.IsOpen then
+  if not Self.IsOpen() then
     Exit(False);
 
   for prayer in prayers do
diff --git a/osrs/interfaces/gametabs/sailing.simba b/osrs/interfaces/gametabs/sailing.simba
@@ -24,7 +24,7 @@ var
   b: TBox;
   isHelm: Boolean;
 begin
-  b := borders.Bounds;
+  b := borders.Bounds();
 
   case b.Height of
     30:
diff --git a/osrs/interfaces/handlers/prayer_form.simba b/osrs/interfaces/handlers/prayer_form.simba
@@ -101,7 +101,7 @@ begin
   img.DrawColor := color;
   img.DrawTPA(highlight);
 
-  Self.PrayerImages[p].Picture.Bitmap := img.ToLazBitmap;
+  Self.PrayerImages[p].Picture.Bitmap := img.ToLazBitmap();
 end;
 
 procedure TRSPrayerForm._UpdateHint();
@@ -350,10 +350,10 @@ begin
   SetLength(Self.PrayerImages, Length(ERSPrayer));
   for i := 0 to Ord(High(ERSPrayer)) do
   begin
-    img := PrayerFinder.GetImage(ERSPrayer(i)).Copy;
+    img := PrayerFinder.GetImage(ERSPrayer(i)).Copy();
     img.ReplaceColor($0, TRSPrayerForm.BACKGROUND_COLOR);
     Self.PrayerImages[i] := TLazImage.Create(Self.Form);
-    Self.PrayerImages[i].Picture.Bitmap := img.ToLazBitmap;
+    Self.PrayerImages[i].Picture.Bitmap := img.ToLazBitmap();
     Self.PrayerImages[i].Top := 9 + ((i div 5) * (33 + 4));
     Self.PrayerImages[i].Left := 7 + ((i mod 5) * (33 + 4));
     Self.PrayerImages[i].Parent := Self.Form;
diff --git a/osrs/interfaces/interfacecontrols.simba b/osrs/interfaces/interfacecontrols.simba
@@ -79,6 +79,9 @@ property TRSButton.Enabled: Boolean;
 var
   i: Integer;
 begin
+  if Self.EnabledColors = [] then
+    raise GetDebugLn('TRSButton', 'This button has no state. Use `TRSButton.Click` instead or add `EnabledColors` to it.');
+
   for i := 0 to High(Self.EnabledColors) do
     if Target.HasColor(Self.EnabledColors[i].Color, Self.EnabledColors[i].Tolerance, 1, Self.Bounds) then
       Exit(True);
diff --git a/osrs/interfaces/mainscreen/bank.simba b/osrs/interfaces/mainscreen/bank.simba
@@ -1534,7 +1534,7 @@ var
   box: TBox;
 begin
   box := Inventory.Slots.Box(slot);
-  Result := Target.FindColor($0000ff, 4, box.Expand(2, 1)).Intersection(box.Expand(1, 0).Corners).Length = 4;
+  Result := Target.FindColor($0000ff, 4, box.Expand(2, 1)).Intersection(box.Expand(1, 0).Corners()).Length = 4;
 end;
 
 (*
diff --git a/osrs/interfaces/mainscreen/collectionbox.simba b/osrs/interfaces/mainscreen/collectionbox.simba
@@ -111,7 +111,7 @@ end;
 
 procedure TRSCollectionBox.Setup();
 begin
-  if Async.Schedules.Contains('CollectionBox.Timer') then Exit;
+  if Async.Schedules().Contains('CollectionBox.Timer') then Exit;
   Async.ScheduleEvery('CollectionBox.Timer', @Self.AsyncTask, 10 * ONE_MINUTE);
   AddOnTerminate(@Self.Free);
 end;
diff --git a/osrs/interfaces/mainscreen/depositbox.simba b/osrs/interfaces/mainscreen/depositbox.simba
@@ -67,7 +67,7 @@ begin
 
   for tpa in atpa do
   begin
-    b := tpa.Bounds;
+    b := tpa.Bounds();
     if b.Height <= 5 then Continue;
     Exit(TBoxArray.Create([Self.SlotsArea.X1, b.Y1 - 1], 4, 7, 32, 32, [10, 4]));
   end;
diff --git a/osrs/interfaces/mainscreen/finders/hpbars.simba b/osrs/interfaces/mainscreen/finders/hpbars.simba
@@ -55,7 +55,7 @@ begin
       Result := True;
       for i:=0 to High(GBars) do
       begin
-        if (not InRange(GBars[i].Bounds.Height, 3, 5)) then Continue;
+        if (not InRange(GBars[i].Bounds().Height, 3, 5)) then Continue;
         Bar    := [];
         Border := [];
         BarG   := [];
@@ -67,29 +67,29 @@ begin
             begin
               Bar := RBars[h];
               Bar.Insert(GBars[i],0);
-              Border := Bar.Bounds;
+              Border := Bar.Bounds();
               BarG := Target.FindColor($00FF00, 0, Border);
               if Length(BarG) > 0 then
               begin
-                AddToBars(Border, Round(BarG.Bounds.Width / Border.Width * 100));
+                AddToBars(Border, Round(BarG.Bounds().Width / Border.Width * 100));
                 break;
               end;
             end else
             begin
               if (h = High(RBars)) then
-                AddToBars(GBars[i].Bounds, 100);
+                AddToBars(GBars[i].Bounds(), 100);
             end;
           end;
-        end else AddToBars(GBars[i].Bounds, 100);
+        end else AddToBars(GBars[i].Bounds(), 100);
       end;
     end else if Length(GBars) = 0 then
     begin
       if Length(RBars) > 0 then
         for i:=0 to High(RBars) do
         begin
-          if (not InRange(RBars[i].Bounds.Height, 3, 5)) then Continue;
-          if (RBars[i].Bounds.Width < 10) then Continue;
-          AddToBars(RBars[i].Bounds, 0);
+          if (not InRange(RBars[i].Bounds().Height, 3, 5)) then Continue;
+          if (RBars[i].Bounds().Width < 10) then Continue;
+          AddToBars(RBars[i].Bounds(), 0);
         end;
     end;
   finally
diff --git a/osrs/interfaces/mainscreen/goldscreen.simba b/osrs/interfaces/mainscreen/goldscreen.simba
@@ -175,7 +175,7 @@ function TRSGoldScreen.WaitOpen(time, interval: Int32): Boolean;
 begin
   if interval < 0 then
     interval := RandomMode(100,50,1500);
-  Result := SleepUntil(Self.IsOpen, interval, time);
+  Result := SleepUntil(Self.IsOpen(), interval, time);
 end;
 
 (*
@@ -195,7 +195,7 @@ begin
             (PressEscape and MSInterface.Close(True));
 
   if Result then
-    Result := SleepUntil(not Self.IsOpen,
+    Result := SleepUntil(not Self.IsOpen(),
                          RandomMode(100,50,1500),
                          Random(1500,2000));
 end;
diff --git a/osrs/interfaces/mainscreen/grandexchange/grandexchange.simba b/osrs/interfaces/mainscreen/grandexchange/grandexchange.simba
@@ -364,7 +364,7 @@ var
 begin
   tpa := Target.FindColor($1964A8, 0, Self.StatusBox);
   if not (tpa = []) then
-    Result := Round(tpa.Bounds.Width() / 105 * 100)
+    Result := Round(tpa.Bounds().Width / 105 * 100)
   else if Target.HasColor($004A00, 0, 1, Self.StatusBox) then
     Result := 100
   else
diff --git a/osrs/interfaces/mainscreen/grandexchange/grandexchange_offer.simba b/osrs/interfaces/mainscreen/grandexchange/grandexchange_offer.simba
@@ -406,7 +406,7 @@ begin
   tpa := Target.FindColor(RSFonts.LIGHT_ORANGE, 0, Self.InfoBounds.Examine);
   if tpa = [] then Exit;
   tpa := tpa.Cluster(12, 8).Last;
-  txt := OCR.Recognize(tpa.Bounds, RSFonts.PLAIN_11, [RSFonts.LIGHT_ORANGE], 0);
+  txt := OCR.Recognize(tpa.Bounds(), RSFonts.PLAIN_11, [RSFonts.LIGHT_ORANGE], 0);
   Result := txt.ExtractInteger(0) / 100;
 end;
 
diff --git a/osrs/interfaces/mainscreen/silverscreen.simba b/osrs/interfaces/mainscreen/silverscreen.simba
@@ -143,7 +143,7 @@ function TRSSilverScreen.WaitOpen(time, interval : Int32) : Boolean;
 begin
   if interval < 0 then
     interval := RandomMode(100,50,1500);
-  Result := SleepUntil(Self.IsOpen, interval, time);
+  Result := SleepUntil(Self.IsOpen(), interval, time);
 end;
 
 (*
@@ -161,15 +161,15 @@ WriteLn SilverScreen.Close(True);
 *)
 function TRSSilverScreen.Close(PressEscape : Boolean) : Boolean;
 begin
-  if not Self.IsOpen then
+  if not Self.IsOpen() then
     Exit(True);
 
   Result := (not PressEscape and MSInterface.Close(False))
             or
             (PressEscape     and MSInterface.Close(True));
 
   if Result then
-    Result := SleepUntil(not Self.IsOpen,
+    Result := SleepUntil(not Self.IsOpen(),
                          RandomMode(100,50,1500),
                          Random(1500,2000));
 end;
@@ -247,7 +247,7 @@ var
   TPA : TPointArray;
   Slot: Integer;
 begin
-  if not Self.IsOpen then Exit;
+  if not Self.IsOpen() then Exit;
 
   if not Self.Items.Find([Item], Slot) then
     Exit;
@@ -279,7 +279,7 @@ var
   box       : TBox;
   TPA       : TPointArray;
 begin
-  if not Self.IsOpen then Exit;
+  if not Self.IsOpen() then Exit;
   if not Self.CanCraftItem(Item, box) then Exit;
   TPA := Target.FindColor(highlight, 2, box);
   Result := TPA.Length > 0;
diff --git a/osrs/interfaces/minimap.simba b/osrs/interfaces/minimap.simba
@@ -1059,15 +1059,15 @@ var
   count: Integer;
 begin
   count := Self.CountColor(color, tolerance);
-  Result := count / Self.Polygon.Area;
+  Result := count / Self.Polygon.Area();
 end;
 
 function TRSMinimap.ColorPercent(color: TColorTolerance): Single; overload;
 var
   count: Integer;
 begin
   count := Self.CountColor(color);
-  Result := count / Self.Polygon.Area;
+  Result := count / Self.Polygon.Area();
 end;
 
 
diff --git a/osrs/interfaces/xpbar.simba b/osrs/interfaces/xpbar.simba
@@ -299,7 +299,7 @@ var
   str: String;
   count: Integer;
 begin
-  if not Self.Setup then Exit;
+  if not Self.Setup() then Exit;
 
   str := OCR.Recognize(Self.Bounds, Self.Font, [$FFFFFF], 0);
 
diff --git a/osrs/overrides.simba b/osrs/overrides.simba
@@ -90,7 +90,7 @@ WriteLn GameTabs.GetCurrent();
 *)
 function TRSGameTabs.GetCurrent(): ERSGameTab; override;
 begin
-  Result := inherited;
+  Result := inherited();
   if Result <> ERSGameTab.NONE then Exit;
 
   if Bank.IsOpen() then Exit(ERSGameTab.INVENTORY);
@@ -174,7 +174,7 @@ begin
   if WorldSwitcher._IsOpen() then
     Exit(True);
   Logout.Buttons[ERSLogoutButton.WORLD_SWITCHER].Click();
-  Result := inherited;
+  Result := inherited();
 end;
 
 {$R-}
diff --git a/osrs/position/map/entities.simba b/osrs/position/map/entities.simba
@@ -387,6 +387,23 @@ begin
 end;
 
 
+(*
+## Entity.IsVisible
+```pascal
+function TRSEntity.IsVisible(): Boolean;
+```
+Returns a boolean whether the entity is currently visible or not.
+*)
+function TRSEntity.IsVisible(): Boolean;
+var
+  coordinates: TPointArray;
+  boundsArray: TPolygonArray;
+  atpa: T2DPointArray;
+begin
+  Result := Self.FindEx(Self.Walker^.Position(), boundsArray, coordinates, atpa);
+end;
+
+
 function TRSEntity.FindFrom(position: TPoint; out atpa: T2DPointArray): Boolean;
 var
   boundsArray: TPolygonArray;
diff --git a/osrs/position/map/mapdebugger.simba b/osrs/position/map/mapdebugger.simba
diff --git a/osrs/position/map/maploader.simba b/osrs/position/map/maploader.simba
diff --git a/osrs/projection/projection.simba b/osrs/projection/projection.simba
diff --git a/utils.simba b/utils.simba
diff --git a/utils/forms/formutils.simba b/utils/forms/formutils.simba
diff --git a/utils/math/random.simba b/utils/math/random.simba
