Skip to content

Commit 95af006

Browse files
Merge pull request #79 from WarehouseFinds/fix/must_use_fetch_tags
Ensure tags are fetched during the build process
2 parents bcd17f2 + 946ed45 commit 95af006

File tree

2 files changed

+2
-26
lines changed

2 files changed

+2
-26
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -30,44 +30,22 @@
3030
### Code Quality
3131

3232
- [ ] Code follows PowerShell best practices and approved verbs
33-
- [ ] All functions include `[CmdletBinding()]` attribute
34-
- [ ] Parameter validation attributes are used appropriately
35-
- [ ] Proper error handling with try/catch blocks is implemented
36-
- [ ] Verbose output is provided for troubleshooting
37-
- [ ] No hard-coded paths, credentials, or sensitive data
3833

3934
### Testing
4035

4136
- [ ] All new functions have corresponding `.Tests.ps1` files
42-
- [ ] Existing tests pass: `Invoke-Build Test`
4337
- [ ] New tests added for new functionality
44-
- [ ] Code coverage is adequate
45-
- [ ] Edge cases are tested (null/empty inputs)
46-
47-
### Code Analysis
48-
49-
- [ ] PSScriptAnalyzer passes: `Invoke-Build Invoke-PSScriptAnalyzer`
50-
- [ ] No new PSScriptAnalyzer warnings introduced
51-
- [ ] Security checks pass (InjectionHunter tests)
5238

5339
### Documentation
5440

5541
- [ ] Comment-based help is complete and accurate
56-
- [ ] Markdown help files updated (if function signatures changed)
5742
- [ ] Examples included in help documentation
5843
- [ ] README.md updated (if applicable)
59-
- [ ] CHANGELOG.md updated (if applicable)
60-
61-
### Module Manifest
62-
63-
- [ ] New public functions added to `FunctionsToExport` in `.psd1`
64-
- [ ] Module manifest version updated (if applicable)
6544

6645
## Related Issues
6746

6847
<!-- Link related issues using #issue_number or 'Fixes #issue_number' for auto-closing -->
69-
70-
Closes #
48+
Fixes #issue_number
7149

7250
## Additional Notes
7351

.github/workflows/powershell-build-module.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ jobs:
3434
repository: ${{ github.repository }}
3535
ref: ${{ inputs['version-tag'] || '' }}
3636
fetch-depth: 0
37-
fetch-tags: true
38-
3937
- name: Install GitVersion tool
4038
uses: gittools/actions/gitversion/setup@d0139503a9321f76b4a417dfdc8aebcec24decdd #v4.2.0
4139
with:
@@ -127,7 +125,7 @@ jobs:
127125
env:
128126
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
129127
run: |
130-
#git fetch --tags
128+
git fetch --tags
131129
# Find previous tag based on release type
132130
# - For 'Prerelease', use the latest tag (Release notes are generated from last commit to latest tag)
133131
# - For 'Release', use the second latest tag (Release notes are generated from last tag to second latest tag)

0 commit comments

Comments
 (0)