Failed to handle large bulk reply

[evelinamihailova]

Feb 19 15:58:03 PQPI-076802be rapid-prototype-runner[295]: 2020-02-19 15:58:03,765 - ERROR: Value error: b'[{"jsonrpc":"2.0","id":179,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:52.510Z"}
}},{"jsonrpc":"2.0","id":180,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:52.596Z"}}},{"jsonrpc":"2.0","id":181,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:52.646Z"
}}},{"jsonrpc":"2.0","id":182,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:52.763Z"}}},{"jsonrpc":"2.0","id":183,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:52.848Z
"}}},{"jsonrpc":"2.0","id":184,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:52.935Z"}}},{"jsonrpc":"2.0","id":185,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:52.975
Z"}}},{"jsonrpc":"2.0","id":186,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.082Z"}}},{"jsonrpc":"2.0","id":187,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.16
7Z"}}},{"jsonrpc":"2.0","id":188,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.253Z"}}},{"jsonrpc":"2.0","id":189,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.2
94Z"}}},{"jsonrpc":"2.0","id":190,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.400Z"}}},{"jsonrpc":"2.0","id":191,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.
483Z"}}},{"jsonrpc":"2.0","id":192,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.569Z"}}},{"jsonrpc":"2.0","id":193,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53
.611Z"}}},{"jsonrpc":"2.0","id":194,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.717Z"}}},{"jsonrpc":"2.0","id":196,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:5
3.731Z"}}},{"jsonrpc":"2.0","id":195,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.814Z"}}},{"jsonrpc":"2.0","id":197,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:'
Feb 19 15:58:03 PQPI-076802be rapid-prototype-runner[295]: 2020-02-19 15:58:03,781 - ERROR: Value error: b'57:53.900Z"}}},{"js'
Feb 19 15:58:03 PQPI-076802be rapid-prototype-runner[295]: 2020-02-19 15:58:03,793 - ERROR: Value error: b'onrpc":"2.0","id":198,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:53.941Z"}}},{"
jsonrpc":"2.0","id":199,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.047Z"}}},{"jsonrpc":"2.0","id":200,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.131Z"}}},{
"jsonrpc":"2.0","id":201,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.217Z"}}},{"jsonrpc":"2.0","id":202,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.258Z"}}},
{"jsonrpc":"2.0","id":203,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.369Z"}}},{"jsonrpc":"2.0","id":204,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.452Z"}}}
,{"jsonrpc":"2.0","id":205,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.538Z"}}},{"jsonrpc":"2.0","id":206,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.578Z"}}
},{"jsonrpc":"2.0","id":207,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.686Z"}}},{"jsonrpc":"2.0","id":208,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.769Z"}
}},{"jsonrpc":"2.0","id":209,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.855Z"}}},{"jsonrpc":"2.0","id":210,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:54.899Z"
}}},{"jsonrpc":"2.0","id":211,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:55.006Z"}}},{"jsonrpc":"2.0","id":212,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:55.089Z
"}}},{"jsonrpc":"2.0","id":213,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:55.175Z"}}},{"jsonrpc":"2.0","id":214,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:55.216
Z"}}},{"jsonrpc":"2.0","id":215,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:55.325Z"}}},{"jsonrpc":"2.0","id":216,"result":{"value":true,"meta":{"server_send_time":"2020-02-19T14:57:55'
Feb 19 15:58:03 PQPI-076802be rapid-prototype-runner[295]: 2020-02-19 15:58:03,806 - ERROR: Value error: b'.409Z"}}},{"jsonrpc'

[KarstenTonnesenSeluxit]

3 issues to fix here... A potential infinite lockup.

1. If an invalid character arrives to the parser, the buffer will keep growing and no other message can be passed. There must be a way to clear the buffer and start from new. Could be a check for bytes received < buffer size.
2. The receive buffer is hardcoded to 2000 bytes, which is not easy to see - it should be a defined value.
3. The error message "value error" does not offer any description to what has happened - it is an incomplete package that we need the rest of before we can parse. If no more data is available, it is an error and the buffer should be cleared.

[tacozMacleo]

This issue are again present.