fix: resolve lint errors

Author: Jake Bromberg

apps/backend/controllers/flowsheet.controller.ts

@@ -213,7 +213,9 @@ export const addEntry: RequestHandler = async (req: Request<object, object, FSEn
             body.track_title === undefined
           ) {
             console.error('Bad Request, Missing Flowsheet Parameters: album_title, artist_name, track_title');
-            res.status(400).json({ message: 'Bad Request, Missing Flowsheet Parameters: album_title, artist_name, track_title' });
+            res
+              .status(400)
+              .json({ message: 'Bad Request, Missing Flowsheet Parameters: album_title, artist_name, track_title' });
           } else {
             const fsEntry: NewFSEntry = {
               ...body,

tests/unit/middleware/errorHandler.test.ts

@@ -2,49 +2,51 @@ import errorHandler from '../../../apps/backend/middleware/errorHandler';
 import WxycError from '../../../apps/backend/utils/error';
 import { Request, Response, NextFunction } from 'express';
 
-function mockResponse(): Response {
+function mockResponse() {
+  const statusMock = jest.fn().mockReturnThis();
+  const jsonMock = jest.fn().mockReturnThis();
   const res = {
-    status: jest.fn().mockReturnThis(),
-    json: jest.fn().mockReturnThis(),
-  };
-  return res as unknown as Response;
+    status: statusMock,
+    json: jsonMock,
+  } as unknown as Response;
+  return { res, statusMock, jsonMock };
 }
 
 const mockReq = {} as Request;
 const mockNext = jest.fn() as NextFunction;
 
 describe('errorHandler middleware', () => {
   it('returns { message } with correct status for WxycError', () => {
-    const res = mockResponse();
+    const { res, statusMock, jsonMock } = mockResponse();
     const error = new WxycError('Album not found', 404);
 
     errorHandler(error, mockReq, res, mockNext);
 
-    expect(res.status).toHaveBeenCalledWith(404);
-    expect(res.json).toHaveBeenCalledWith({ message: 'Album not found' });
+    expect(statusMock).toHaveBeenCalledWith(404);
+    expect(jsonMock).toHaveBeenCalledWith({ message: 'Album not found' });
   });
 
   it('returns generic message for non-WxycError (does not leak internals)', () => {
-    const res = mockResponse();
+    const { res, statusMock, jsonMock } = mockResponse();
     const error = new Error('SELECT * FROM users failed: connection refused');
 
     errorHandler(error, mockReq, res, mockNext);
 
-    expect(res.status).toHaveBeenCalledWith(500);
-    expect(res.json).toHaveBeenCalledWith({ message: 'Internal server error' });
+    expect(statusMock).toHaveBeenCalledWith(500);
+    expect(jsonMock).toHaveBeenCalledWith({ message: 'Internal server error' });
   });
 
   it('handles non-Error values thrown', () => {
-    const res = mockResponse();
+    const { res, statusMock, jsonMock } = mockResponse();
 
     errorHandler('something broke', mockReq, res, mockNext);
 
-    expect(res.status).toHaveBeenCalledWith(500);
-    expect(res.json).toHaveBeenCalledWith({ message: 'Internal server error' });
+    expect(statusMock).toHaveBeenCalledWith(500);
+    expect(jsonMock).toHaveBeenCalledWith({ message: 'Internal server error' });
   });
 
   it('logs non-WxycError errors to console', () => {
-    const res = mockResponse();
+    const { res } = mockResponse();
     const error = new Error('db connection lost');
     const consoleSpy = jest.spyOn(console, 'error').mockImplementation();