fix(provider): dedupe streaming usage reports#145
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves streaming behavior in the DeepSeek SSE client by deduplicating per-chunk usage emissions (forwarding only the final usage payload) and hardening downstream VS Code usage reporting so failures don’t disrupt replay marker reporting or cache diagnostics.
Changes:
- Accumulate
usageduring SSE streaming and emit it once at stream completion ([DONE]or EOF). - Wrap VS Code
LanguageModelDataPartusage reporting in atry/catchand log failures with request context. - Thread
requestKindthrough usage reporting to keep logging consistent with existing request-scoped logs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/provider/stream.ts | Guards Copilot usage data part reporting so exceptions don’t block replay markers/diagnostics; logs failures with requestKind. |
| src/client/core.ts | Dedupes streaming usage reports by retaining only the latest usage and emitting it once when the stream completes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #134
Test plan