Enabling strict Typescript reveals 118 errors

[paazmaya]

Any plans on enabling Typescript strict mode?

Currently it seems to

Found 118 error(s).

[pashidlos]

no plans atm
would you like to take it?

[paazmaya]

Ok, I cannot promise to solve all, but I can promise to look at them while doing other things...

[paazmaya]

Current state:

Found 183 errors in 53 files.

Errors  Files
     2  prisma/seed.ts:31
     1  src/auth/auth.service.ts:12
     1  src/auth/guards/role.guard.ts:45
     3  src/builds/builds.controller.ts:93
     3  src/builds/builds.service.spec.ts:101
     4  src/builds/builds.service.ts:28
     1  src/builds/dto/build-create.dto.ts:19
     1  src/builds/dto/build-paginated.dto.ts:7
    17  src/builds/dto/build.dto.spec.ts:45
     6  src/builds/dto/build.dto.ts:46
     1  src/compare/compare.service.ts:21
     5  src/compare/libs/consts.ts:5
     1  src/compare/libs/looks-same/looks-same.service.spec.ts:70
     2  src/compare/libs/looks-same/looks-same.service.ts:57
     1  src/compare/libs/odiff/odiff.service.spec.ts:69
     1  src/compare/libs/pixelmatch/pixelmatch.service.spec.ts:62
     1  src/main.ts:26
    11  src/projects/dto/project.dto.ts:9
     3  src/projects/projects.service.ts:24
     2  src/shared/dto/baseline-data.dto.ts:7
     7  src/shared/dto/baseline.dto.ts:7
     3  src/shared/dto/pagination.dto.ts:5
     1  src/shared/events/events.gateway.ts:11
     3  src/shared/static/static.service.ts:37
     1  src/test-runs/dto/create-test-request-base64.dto.ts:10
     1  src/test-runs/dto/create-test-request-multipart.dto.ts:16
     2  src/test-runs/dto/create-test-request.dto.ts:10
     4  src/test-runs/dto/ignore-area.dto.ts:7
     1  src/test-runs/dto/testRun-paginated.dto.ts:7
    11  src/test-runs/dto/testRun.dto.ts:52
     2  src/test-runs/dto/testRunResult.dto.ts:15
     2  src/test-runs/dto/update-ignore-area.dto.ts:10
     1  src/test-runs/dto/update-test.dto.ts:7
     1  src/test-runs/test-runs.controller.ts:64
     1  src/test-runs/test-runs.service.spec.ts:339
    15  src/test-runs/test-runs.service.ts:42
     9  src/test-variations/dto/base-test-variation.dto.ts:5
     1  src/test-variations/dto/test-variation.dto.ts:7
     3  src/test-variations/test-variations.controller.ts:29
    10  src/test-variations/test-variations.service.ts:30
     3  src/test-variations/types.ts:5
     2  src/users/dto/assign-role.dto.ts:8
     4  src/users/dto/user-create.dto.ts:7
     2  src/users/dto/user-login-request.dto.ts:7
     1  src/users/dto/user-login-response.dto.ts:11
     3  src/users/dto/user-update.dto.ts:7
     2  src/users/dto/user.dto.ts:26
     2  src/users/users.service.ts:35
     1  test/builds.e2e-spec.ts:79
     1  test/preconditions.ts:60
     7  test/test-runs.e2e-spec.ts:251
     7  test/users.e2e-spec.ts:32
     2  test_acceptance/acceptance.spec.ts:16

[paazmaya]

Today

Found 183 errors in 53 files.