Skip to content

Null dereference inside LinearView::mouseDoubleClickEvent when trying to expand a collapsed function #8238

@sentry

Description

@sentry

Sentry Issue: BINARYNINJA-B3

EXC_BAD_ACCESS / KERN_INVALID_ADDRESS / 0x10: Fatal Error: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS / 0x10
  File "function.cpp", line 220, in BinaryNinja::Function::GetStart
  File "qwidget.cpp", in QWidget::event
  File "qframe.cpp", line 522, in QFrame::event
  File "qcoreapplication.cpp", line 1246, in QCoreApplicationPrivate::sendThroughObjectEventFilters
  File "qapplication.cpp", line 3299, in QApplicationPrivate::notify_helper
...
(35 additional frame(s) were not displayed)

@bdash says:

This can be reproduced in single function view with disassembly showing by hitting Cmd-A to select all lines in a function, clicking the collapse marker in the function header to collapse all lines, double-clicking on the same function's name to return back to the single function view, then double-clicking on the collapse marker in the function header to expand all lines.

The immediate cause of the crash is that line.function is null within the path that handles FunctionHeaderLineType.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Effort: LowIssues require < 1 week of workImpact: MediumIssue is impactful with a bad, or no, workaroundUI: LinearIssues with the Linear view

    Type

    No fields configured for Crash.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions