Redundant Size Suffixes

[ElykDeer]

Version and Platform (required):

• Binary Ninja Version: 5.3.9208
• Edition: Ultimate
• OS: OSX
• OS Version: 26.3
• CPU Architecture: M3

Bug Description:
(There are two bugs here) When using the magic structure creation workflow on the following binary (starting at the malloc call at the end of the first basic block), Binary Ninja creates a double on a field that's used in a four-byte assignment and a 4-byte read. It then renders those reads as var.d.d (which is the bug I'm filing for).

Steps To Reproduce:

1. Open attached binary
2. Click s on the malloc near the end of the first basic block
3. Press s on the rest of the offset annotations
4. Renders redundant .d's on accesses

Expected Behavior:
We should only show one .d

Screenshots/Video Recording:

Binary:
structure.elf.zip

Additional Information:
When you correct the type to a float from a double, it renders correctly. But I feel like we shouldn't ever display .d.d

[CouleeApps]

What's it look like if you enable Show IL Opcodes?

[ElykDeer]

[CouleeApps]

Two HLIL_STRUCT_FIELDs in a a row is interesting. I tried reproducing based on your desc and I only see one field deref here. Does it happen for you if you disable plugins and/or can you upload a bndb?

[ElykDeer]

This is an old bndb, but it's consistently reproing with plugins disabled as well

redundant.d.d-annotation.bndb.zip

[CouleeApps]

Looks like it's part of the HLIL expression folding pass

[CouleeApps]

... maybe? It's a var_field of a load_struct in MLIL which then turns into a two struct_fields of a deref_field in HLIL.