test(phase 2): add critical-path test coverage across Domain / Application / Infrastructure layers

[Vasar007]

Phase: Phase 2 of Milestone v0.9.8 (Test Coverage & Agent-Testable Feedback Loop).

Goal

Identify the critical paths and business scenarios across Domain, Application, and Infrastructure layers and back them with a deliberate mix of unit, integration, and contract tests — running in the right CI stages and surfacing a coverage report for visibility, without committing to a 100 % gate.

Requirements Addressed

• TEST-01 — Checked-in document enumerates critical paths across Domain (appraisal logic, model invariants, F# policy / activities), Application (Shell, ShellBuilder, DataflowPipeline, Executors), and Infrastructure (DB + TMDb / OMDb / Steam adapters) layers and maps each path to its covering tests.
• TEST-02 — Unit tests cover Domain-layer logic gaps surfaced by the TEST-01 inventory.
• TEST-03 — Application-layer tests cover orchestration paths (Shell / ShellBuilder / DataflowPipeline composition, Executors wiring).
• TEST-04 — Infrastructure / integration tests run against a real DB (Testcontainers) and exercise TMDb / OMDb / Steam adapters via a real contract or recorded fixture.
• TEST-05 — CI build distinguishes unit / integration / contract stages, runs them in the right order, and stops silently skipping the F# ProjectV.ContentDirectories.Tests project.
• TEST-06 — Coverage report is produced on every CI run and reachable from the build summary (artifact); no hard coverage gate enforced — visibility only.

Scope

This phase adds critical-path test coverage as a single long-lived branch that merges to master via one PR. The implementation lands in the following committed surfaces:

• Test projects under Sources/Tests/ — ProjectV.Tests.Shared (base classes, generators, mock builders, fixtures: TestWebApplicationFactory, TestJwtHelper, TestTelegramBotClientBuilder, FakeHttpMessageHandler, NLog initializer, TestDbHelper / DbCollection), plus per-area test projects for Models, Appraisers, Core, Crawlers, DataPipeline, Executors, InputProcessing, OutputProcessing, Tmdb/Omdb/SteamService (contract via WireMock.Net), DataAccessLayer (integration via Testcontainers Postgres), CommunicationWebService (JWT integration via WebApplicationFactory), and TelegramBotWebService (webhook + polling integration).
• CI rewrite in .github/workflows/build.yml — four named test stages on ubuntu-latest (Test (Unit) / Test (Integration) / Test (Contract) / Test (F#)) plus Test (Non-Docker) on windows-latest, with Coverlet XPlat Code Coverage collection on every C# stage and ReportGenerator merge → coverage artifact + GitHub Step Summary section.
• Initial EF Core migrations under Sources/Libraries/ProjectV.DataAccessLayer/Migrations/ to back the DAL integration tests.
• Critical-path inventory doc at Docs/Testing/Coverage/test-coverage.md + scenarios overview docs under Docs/Testing/Scenarios/.
• Recorded HTTP fixtures under Sources/Tests/Fixtures/{Tmdb,Omdb,Steam}/ (7 JSON files).

Approximate size: 124 files changed, +10880 / −99 (52 commits merged via PR #342).

Out of Scope

• 100 % coverage (visibility only — explicitly not the goal per REQUIREMENTS.md).
• WPF DesktopApp test infrastructure (deferred to a future backlog issue).
• Telegram polling dead-code cleanup (tracked separately on issue refactor(telegram-bot): remove dead polling/receivers classes left by Telegram.Bot 22.10 upgrade #338).
• Architectural rewrite of Shell / ShellBuilder / DataflowPipeline.

Tracking

• PR linked from this issue once opened.
• Closing summary will follow merge.

[Vasar007]

Phase 2 — implementation complete, ready for merge.

Goal: back the existing TPL-Dataflow + ShellBuilder pipeline with critical-path tests across Domain / Application / Infrastructure layers, with CI stages distinguishing unit / integration / contract / F# and a coverage report visible on every run (visibility-only, no hard gate).

What's done

• 52 commits, +10880 / −99 across 124 files. Test surface (committed under Sources/Tests/):
  • ProjectV.Tests.Shared — base classes, generators, mock builders, fixtures (TestWebApplicationFactory, TestJwtHelper, TestTelegramBotClientBuilder, FakeHttpMessageHandler, NLog initializer, TestDbHelper / DbCollection).
  • Domain unit tests — ProjectV.Models.Tests + extended ProjectV.Appraisers.Tests (83 Unit-tagged tests across model invariants + appraisal logic).
  • Application unit tests — ProjectV.Core.Tests (Shell + ShellBuilder + CommunicationServiceClient + Polly retry), ProjectV.Crawlers.Tests, ProjectV.Executors.Tests, ProjectV.InputProcessing.Tests, ProjectV.OutputProcessing.Tests.
  • Pipeline integration tests — ProjectV.DataPipeline.Tests against the live DataflowPipeline composition.
  • Contract tests via WireMock.Net — ProjectV.{Tmdb,Omdb,Steam}Service.Tests against 7 recorded JSON fixtures in Sources/Tests/Fixtures/{Tmdb,Omdb,Steam}/.
  • DAL integration tests via Testcontainers PostgreSQL — ProjectV.DataAccessLayer.Tests + initial EF Core migrations under Sources/Libraries/ProjectV.DataAccessLayer/Migrations/.
  • JWT integration tests — ProjectV.CommunicationWebService.Tests via WebApplicationFactory + TestJwtHelper (closes the JWT runtime test deferred from Phase 1).
  • Telegram integration tests — ProjectV.TelegramBotWebService.Tests covering both webhook and polling paths.
• CI four-stage rewrite in .github/workflows/build.yml: Test (Unit) / Test (Integration) / Test (Contract) / Test (F#) on ubuntu-latest, with Test (Non-Docker) on windows-latest (Integration suite skipped on Windows — Docker dependency).
• Coverage publication via Coverlet XPlat Code Coverage → ReportGenerator merge → artifact upload + summary written to GitHub Step Summary. No --threshold flag — visibility-only per TEST-06.
• Critical-path inventory doc at Docs/Testing/Coverage/test-coverage.md + scenarios overview docs in Docs/Testing/Scenarios/.
• All 6 requirements satisfied (TEST-01..TEST-06). All roadmap success criteria for this phase met.
• PR opened: test(phase 2): add critical-path test coverage across Domain / Application / Infrastructure layers #342 (links this issue via Closes #341).

What deviated from the plan

• An extra implementation sub-task was added after the post-implementation review surfaced four findings: RefreshTokenDbInfo ctor not guarding Guid.Empty, a multi-row filter assertion gap on FindByUserIdAsync, and duplication of the NLog initializer + FakeHttpMessageHandler that needed hoisting into ProjectV.Tests.Shared. All four landed before the PR was opened. A follow-on audit-team review then triggered three doc-only iterations on EF + NLog code comments and a TokenHash assertion gap; all closed.
• No GitHub Issue was opened at sub-task kick-off — this Issue (test(phase 2): add critical-path test coverage across Domain / Application / Infrastructure layers #341) was created retroactively at PR-opening time against the PR template's "no PR without an issue" rule. Acknowledged as a one-off concession by the user; the workflow rule has been recorded to prevent recurrence on Phase 3.
• No other scope changes — REQ-IDs and sub-task boundaries held as originally filed.

Verification

• CI build: run #26114823869 (tip bf10646) — success on both ubuntu-latest and windows-latest jobs.
  • Test (Unit) ✓ | Test (Integration) ✓ | Test (Contract) ✓ | Test (F#) ✓ | Test (Non-Docker) ✓ (Windows) | Format check ✓ | coverage artifact uploaded + summary written.
• CodeQL: last completed run #26112484951 success.

Next

• Review + merge PR test(phase 2): add critical-path test coverage across Domain / Application / Infrastructure layers #342 (master branch-protection gates: CodeQL + Build (ubuntu) + Build (windows), linear history).
• On merge: closing-summary comment lands on this Issue; Phase 3 work opens against the same milestone v0.9.8.

(update comment posted by Claude Code at 2026-05-19T17:53:43Z; sanitized 2026-05-19 to remove internal-pipeline artifact references per project policy.)