v1.16.8 release does not compile because some includes are wrong

[risa2000]

I created a pull request to explain the problem #1524.

[ArchangeGabriel]

I’ve got another issue with this release even after patching for this one:

/build/openvr/src/openvr-1.16.8/src/vrcommon/strtools_public.cpp: In function ‘std::string Format(const char*, ...)’:
/build/openvr/src/openvr-1.16.8/src/vrcommon/strtools_public.cpp:124:2: error: ‘va_start’ was not declared in this scope
  124 |  va_start( args, pchFormat );
      |  ^~~~~~~~
/build/openvr/src/openvr-1.16.8/src/vrcommon/strtools_public.cpp:126:2: error: ‘va_end’ was not declared in this scope
  126 |  va_end( args );
      |  ^~~~~~

Did you fix it too?

[ChristophHaag]

Are you on Linux/gcc/clang? Maybe msvc doesn't require it.

It's a simple missing include
https://aur.archlinux.org/cgit/aur.git/tree/0001-Add-include-stdarg.h-to-strtools_public.cpp.patch?h=openvr-git&id=7fc22be4d823ac8e9a01bdd2b6b5d10c7b762dbd

[ArchangeGabriel]

I’m actually building for Arch. ;p Thanks for the patch! :) Also now I’m wondering if there is a point in your openvr-git package since basically commits match releases here…