hotfix: remove import allScript

Author: HoangTran0410

README-en.md

@@ -32,11 +32,12 @@ Try online [Here](https://useful-scripts-extension.github.io/useful-script/popup
 
 Current Versions:
 
-- **v2.0**: Hotfix bug crash popup
+- **v2.1**: Fix optimization error: remove import @allScripts in storageScripts.js
 
 <details>
   <summary>Old versions</summary>
 
+- <del>- **v2.0**: Hotfix bug crash popup</del>
 - <del>- **v1.9**: optimize scripts, load popup faster than x100 (ERROR)</del>
 - <del>- **v1.8**: douyin + facebook + youtube update 22/08/2024</del>
 - <del>v1.7: tiktok update (28/07/2024)</del>

README.md

@@ -32,11 +32,12 @@ Xem [Lịch sử cập nhật](/md/CHANGELOGS.md)
 
 Phiên bản hiện tại:
 
-- **v2.0**: Hotfix bug crash popup
+- **v2.1**: Sửa lỗi tối ưu hoá: xoá import @allScripts trong storageScripts.js
 
 <details>
   <summary>Xem phiên bản cũ hơn</summary>
 
+- <del>- **v2.0**: Hotfix bug crash popup</del>
 - <del>- **v1.9**: tối ưu hoá script, load popup nhanh hơn x100 (LỖI)</del>
 - <del>- **v1.8**: douyin + facebook + youtube update 22/08/2024</del>
 - <del>v1.7: tiktok update (28/07/2024)</del>

manifest.json

@@ -4,7 +4,7 @@
   "name": "Useful Scripts",
   "description": "Scripts that can make your life faster and better",
   "homepage_url": "https://github.com/Useful-Scripts-Extension/useful-script",
-  "version": "2.0",
+  "version": "2.1",
   "icons": {
     "16": "./assets/icon16.png",
     "32": "./assets/icon32.png",

md/CHANGELOGS.md

@@ -1,5 +1,13 @@
 ## Change logs
 
+<details>
+  <summary>v2.1 - 26/11/2025</summary>
+
+- Optimize popup loading time, load popup faster than x100
+- Fix import @allScripts in storageScripts.js
+
+</details>
+
 <details>
   <summary>v2.0 - 08/11/2025</summary>
 

md/claude-fix/OPTIMIZATION_DONE.md

@@ -23,7 +23,14 @@ Popup loading optimization has been successfully implemented using lazy loading
 - Updated auto-run checkbox handler to lazy load
 - Updated restore settings to use lazy loading
 
-### 4. Created `package.json`
+### 4. Updated `popup/helpers/storageScripts.js` (NEW)
+
+- **Before:** Imported full scripts via `@allScripts.js`
+- **After:** Imports only metadata via `@metadata.js`
+- Fixed `getIds()` filter to check against metadata
+- Fixed `get()` to return metadata objects
+
+### 5. Created `package.json`
 - Added build script: `npm run build:metadata`
 - Set type to "module" for ES6 imports
 
@@ -91,7 +98,8 @@ Created:
 
 Modified:
 ├── popup/tabs.js                       # Now uses metadata
-└── popup/index.js                      # Added lazy loading
+├── popup/index.js                      # Added lazy loading
+└── popup/helpers/storageScripts.js     # Now uses metadata (fixed!)
 ```
 
 ## 🔄 Development Workflow
@@ -174,6 +182,7 @@ export { onClick } from './script-impl.js';
 - [x] Metadata file generated (173 scripts)
 - [x] popup/tabs.js uses metadata
 - [x] popup/index.js implements lazy loading
+- [x] popup/helpers/storageScripts.js uses metadata (FIXED!)
 - [x] runScript() lazy loads before execution
 - [x] Auto-run toggle lazy loads before onEnable/onDisable
 - [x] Restore settings lazy loads scripts

popup/helpers/storageScripts.js

@@ -1,9 +1,11 @@
-import allScripts from "../../scripts/@allScripts.js";
+// ⚡ LAZY LOADING OPTIMIZATION
+// Import only metadata instead of full scripts for faster popup loading
+import metadata from "../../scripts/@metadata.js";
 
 const createScriptsSaver = (key, addToHead = true) => {
   const getIds = () =>
     JSON.parse(localStorage.getItem(key) ?? "[]").filter(
-      (savedScriptId) => savedScriptId in allScripts
+      (savedScriptId) => savedScriptId in metadata
     );
   const has = (script) => {
     let current = getIds();
@@ -31,7 +33,7 @@ const createScriptsSaver = (key, addToHead = true) => {
   const clear = () => {
     localStorage.setItem(key, "[]");
   };
-  const get = () => getIds().map((savedScriptId) => allScripts[savedScriptId]);
+  const get = () => getIds().map((savedScriptId) => metadata[savedScriptId]);
 
   return { add, remove, has, toggle, clear, getIds, get };
 };

popup/tabs.js

@@ -14,28 +14,32 @@ const createTitle = (en, vi) => ({ name: { en, vi } });
 
 // Create script proxy from metadata (lightweight, no implementation code)
 // Add dummy context objects so canClick() and canAutoRun() work correctly
-const s = {};
 const dummyFn = () => {}; // Placeholder function
+const s = Object.entries(metadata).reduce((acc, [id, meta]) => {
+  acc[id] = enrichMetadata(meta);
+  return acc;
+}, {});
 
-Object.entries(metadata).forEach(([id, meta]) => {
-  s[id] = {
+function enrichMetadata(meta) {
+  const res = {
     ...meta,
     // Add context objects with dummy functions based on metadata
     // This allows popup/helpers/utils.js to correctly identify clickable scripts
     // Real functions are loaded lazily in index.js
     popupScript: meta.contexts?.popup ? { onClick: dummyFn } : undefined,
     contentScript: meta.contexts?.content ? { onClick: dummyFn } : undefined,
     pageScript: meta.contexts?.page ? { onClick: dummyFn } : undefined,
-    backgroundScript: meta.contexts?.background ? { onClick: dummyFn } : undefined,
+    backgroundScript: meta.contexts?.background
+      ? { onClick: dummyFn }
+      : undefined,
   };
-
-  // If marked as canAutoRun, add dummy lifecycle function
   if (meta.canAutoRun) {
-    if (s[id].contentScript) s[id].contentScript.onDocumentIdle = dummyFn;
-    if (s[id].pageScript) s[id].pageScript.onDocumentIdle = dummyFn;
-    if (s[id].backgroundScript) s[id].backgroundScript.onDocumentIdle = dummyFn;
+    if (res.contentScript) res.contentScript.onDocumentIdle = dummyFn;
+    if (res.pageScript) res.pageScript.onDocumentIdle = dummyFn;
+    if (res.backgroundScript) res.backgroundScript.onDocumentIdle = dummyFn;
   }
-});
+  return res;
+}
 
 const specialTabs = [
   {
@@ -401,10 +405,12 @@ const allScriptInTabs = [
 async function refreshSpecialTabs() {
   // add data to special tabs
   let recentTab = specialTabs.find((tab) => tab.id === CATEGORY.recently.id);
-  if (recentTab) recentTab.scripts = recentScriptsSaver.get();
+  if (recentTab)
+    recentTab.scripts = recentScriptsSaver.get().map(enrichMetadata);
 
   let favoriteTab = specialTabs.find((tab) => tab.id === CATEGORY.favorite.id);
-  if (favoriteTab) favoriteTab.scripts = favoriteScriptsSaver.get();
+  if (favoriteTab)
+    favoriteTab.scripts = favoriteScriptsSaver.get().map(enrichMetadata);
 
   let allTab = specialTabs.find((tab) => tab.id === CATEGORY.all.id);
   if (allTab) allTab.scripts = sortScriptsByTab(allScriptInTabs, tabs);