error handeling in topic plugin

Author: lagaffe

README.md

@@ -47,6 +47,8 @@ with the user names of the sudoers in the users array (you can allways add some
 
 For a minimal setup, add `--local` so that lechbot won't try to poll from twitter or other distant APIs.
 
+Il peut être nécessaire de mettre a jour yt-dlp pour que !motd fonctionne correctement
+
 ### Connect to irc
 
 `$ python lechbot.py --irc [ --debug ]`

ircbot/persist.py

@@ -1,14 +1,17 @@
 import json
 import logging
 from copy import deepcopy
+from os import path
 from fcntl import LOCK_EX, LOCK_UN, flock
 
 logger = logging.getLogger()
 
 
 class Persistent:
     def __init__(self, file):
-        self.file = file
+        self.file = path.join("data", file)
+        self.db = None
+        self._initial = self.db
 
     def __enter__(self):
         try:
@@ -18,11 +21,12 @@ def __enter__(self):
         flock(self.fd, LOCK_EX)
         try:
             self.db = json.load(self.fd)
+            self._initial = deepcopy(self.db)
             logger.debug("Loaded " + repr(self.db) + " from " + self.file)
         except:
             logger.exception("Cannot load from " + self.file)
             self.db = {}
-        self._initial = deepcopy(self.db)
+
         return self.db
 
     def __exit__(self, *args, **kwargs):

plugins/topic.py

@@ -1,6 +1,6 @@
 import re
 from datetime import datetime
-from time import time
+from time import time, sleep
 
 from yt_dlp import YoutubeDL
 
@@ -34,9 +34,13 @@ def make_topic(self, msg, new_topic=None, new_music=None):
 
     def find_title(self, url):
         with YoutubeDL() as ydl:
-            info_dict = ydl.extract_info(url, download=False)
-            video_title = info_dict.get("title", None)
-        return video_title
+            try:
+                info_dict = ydl.extract_info(url, download=False)
+                video_title = info_dict.get("title", None)
+                return video_title
+            except:
+                self.bot.log.exception("could not find title")
+                return None
 
     @BotPlugin.command(r"\!motd +(https?://[^ ]+)")
     async def music_of_the_day(self, msg):
@@ -63,14 +67,14 @@ async def music_of_the_day(self, msg):
         except ApiError as e:
             if e.error_type == "TRY_AGAIN_TOMORROW":
                 msg.reply("La musique du jour a déjà été changée aujourd'hui !")
+                return
 
         self.bot.log.info("Music of the day changed by " + msg.user)
         self.make_topic(msg, new_music=music_url)
-        try:
-            title = self.find_title(music_url)
-        except:
-            self.bot.log.exception("Fetch MotD title")
-            title = ""
+
+        title = self.find_title(music_url)
+        title = title if title else music_url
+
         fmt = "tu viens de changer la musique du jour >>> d*-*b <<< {}"
         msg.reply(fmt.format(self.bot.text.bold(title)), hilight=True)
 

requirements.txt

@@ -4,111 +4,103 @@
 #
 #    pip-compile
 #
-aioauth-client==0.28.1
+aioauth-client==0.29.0
     # via -r requirements.in
-aiohttp==3.8.6
-    # via -r requirements.in
-aiosignal==1.3.1
+aiohappyeyeballs==2.6.1
     # via aiohttp
-anyio==3.6.2
-    # via httpcore
-async-timeout==4.0.2
+aiohttp==3.11.15
+    # via -r requirements.in
+aiosignal==1.3.2
     # via aiohttp
+anyio==4.9.0
+    # via httpx
 asyncio-irc @ git+https://github.com/titouanc/asyncirc
     # via -r requirements.in
-attrs==22.2.0
+attrs==25.3.0
     # via aiohttp
-beautifulsoup4==4.12.2
+beautifulsoup4==4.13.3
     # via -r requirements.in
-blinker==1.5
+blinker==1.9.0
     # via asyncio-irc
-brotli==1.0.9
-    # via yt-dlp
-build==0.9.0
+build==1.2.2.post1
     # via pip-tools
-certifi==2022.12.7
+certifi==2025.1.31
     # via
     #   httpcore
     #   httpx
     #   sentry-sdk
-    #   yt-dlp
-charset-normalizer==2.1.1
-    # via aiohttp
-click==8.1.3
+click==8.1.8
     # via pip-tools
-frozenlist==1.3.3
+frozenlist==1.5.0
     # via
     #   aiohttp
     #   aiosignal
 h11==0.14.0
     # via httpcore
-httpcore==0.16.3
+httpcore==1.0.7
     # via httpx
-httpx==0.23.2
+httpx==0.28.1
     # via aioauth-client
-humanize==4.6.0
+humanize==4.12.2
     # via -r requirements.in
-idna==3.4
+idna==3.10
     # via
     #   anyio
-    #   rfc3986
+    #   httpx
     #   yarl
-iniconfig==2.0.0
+iniconfig==2.1.0
     # via pytest
-multidict==6.0.4
+multidict==6.3.0
     # via
     #   aiohttp
     #   yarl
-mutagen==1.46.0
-    # via yt-dlp
-packaging==22.0
+packaging==24.2
     # via
     #   build
     #   pytest
-pep517==0.13.0
-    # via build
-pip-tools==6.13.0
+pip-tools==7.4.1
     # via -r requirements.in
-pluggy==1.0.0
+pluggy==1.5.0
     # via pytest
-pycryptodomex==3.19.1
-    # via yt-dlp
-pytest==7.3.2
+propcache==0.3.1
+    # via
+    #   aiohttp
+    #   yarl
+pyproject-hooks==1.2.0
+    # via
+    #   build
+    #   pip-tools
+pytest==8.3.5
     # via
     #   -r requirements.in
     #   pytest-asyncio
-pytest-asyncio==0.21.0
+pytest-asyncio==0.26.0
     # via -r requirements.in
-python-dateutil==2.8.2
+python-dateutil==2.9.0.post0
     # via -r requirements.in
-pytz==2023.3
+pytz==2025.2
     # via -r requirements.in
-rfc3986[idna2008]==1.5.0
-    # via
-    #   httpx
-    #   rfc3986
-roman==4.1
+roman==5.0
     # via -r requirements.in
-sentry-sdk==1.28.1
+sentry-sdk==2.25.0
     # via -r requirements.in
-six==1.16.0
+six==1.17.0
     # via python-dateutil
-sniffio==1.3.0
+sniffio==1.3.1
+    # via anyio
+soupsieve==2.6
+    # via beautifulsoup4
+typing-extensions==4.13.0
     # via
     #   anyio
-    #   httpcore
-    #   httpx
-soupsieve==2.3.2.post1
-    # via beautifulsoup4
-urllib3==1.26.13
+    #   beautifulsoup4
+urllib3==2.3.0
     # via sentry-sdk
-websockets==10.4
-    # via yt-dlp
-wheel==0.40.0
+wheel==0.45.1
     # via pip-tools
-yarl==1.8.2
+yarl==1.18.3
     # via aiohttp
-yt-dlp==2023.10.7
+yt-dlp==2025.3.31
     # via -r requirements.in
 
 # The following packages are considered to be unsafe in a requirements file: