Skip to content

Commit 9dd5593

Browse files
committed
Fix issue with settings not chaing encoder when the codec changes
1 parent 7b9641d commit 9dd5593

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
**<span style="color:#56adda">0.1.16</span>**
22
- Add support for using the File Metadata helper for storing details on moved files (Requires Unmanic v0.3.0)
3+
- Fix issue with settings not chaing encoder when the codec changes
34

45
**<span style="color:#56adda">0.1.15</span>**
56
- Add a warning against using "Prefer Quality" when scaling a video down

lib/global_settings.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,12 @@ def get_video_encoder_form_settings(self):
197197
"label": encoder_details.get('label'),
198198
}
199199
)
200-
self.__set_default_option(values['select_options'], 'video_encoder')
200+
selected_encoder = self.__set_default_option(values['select_options'], 'video_encoder')
201+
if getattr(self.settings, 'apply_default_fallbacks', True):
202+
current_encoder = self.settings.get_setting('video_encoder')
203+
if selected_encoder and selected_encoder != current_encoder:
204+
# Persist a compatible encoder when codec selection changes and invalidates the current value.
205+
self.settings.set_setting('video_encoder', selected_encoder)
201206
if self.settings.get_setting('mode') not in ['basic', 'standard']:
202207
values["display"] = 'hidden'
203208
return values

0 commit comments

Comments
 (0)